[pull] master from ruby:master#921
Merged
pull[bot] merged 4 commits intoturkdevops:masterfrom Apr 10, 2026
Merged
Conversation
This caused out of bounds writes because of converting to a st_table. Co-authored-by: Luke Gruber <luke.gru@gmail.com> Co-authored-by: Matt Valentine-House <matt@eightbitraptor.com>
Co-authored-by: Luke Gruber <luke.gru@gmail.com> Co-authored-by: Matt Valentine-House <matt@eightbitraptor.com>
Every class boots with a metaclass, and all metaclasses are subclasses of Class, so `types::Class` has no business in `ExactBitsAndClass`. In fact, we should never see an object whose RBasic::class is exactly rb_cClass because classes get a metaclass on boot. So there is no ClassExact type. This fixes the side exits on getivar-module.rb that were introduced in a8f3c34 ("ZJIT: Add missing guard on ivar access on T_{DATA,CLASS,MODULE}"). The `GuardType v, Class` checked for exactly rb_cClass and never passed.
Although the issue only occurred on debug builds, we should always be requesting a size large enough to fit the object when it expands to the heap, rather than just hoping the GC provides enough room.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )