Skip to content

[pull] master from php:master#842

Merged
pull[bot] merged 6 commits intoturkdevops:masterfrom
php:master
Apr 6, 2026
Merged

[pull] master from php:master#842
pull[bot] merged 6 commits intoturkdevops:masterfrom
php:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Apr 6, 2026 •
edited
Loading

See Commits and Changes for more details.

Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

TimWolla and others added 6 commits April 6, 2026 14:46
@TimWolla
zend_portability: Remove EMPTY_SWITCH_DEFAULT_CASE() (#20063)
04f06e8 
There are several issues with this macro:

- It is incorrectly named: It's not an empty default case. It's an unreachable
  default case.
- It is hiding control flow in its definition, which can be confusing for
  humans and tools (such as Coccinelle) alike, because it looks like it would
  be a statement that belongs to the "current" case rather than opening a new
  one.

Since this macro is exactly as long as explicitly spelling out its definition
(excluding the useless `break;`), it is not even making the code any more
succinct.
@TimWolla
Drop EMPTY_SWITCH_DEFAULT_CASE() exclusion from build/Makefile.gcov
3080507
@LamentXU123
ext/zip: Preinitialize arrays when size is known (#21572)
7d5847d
@TimWolla
Adjust ZEND_UNREACHABLE() exclusion in build/Makefile.gcov
02dab7f 
These patterns are implicitly anchored, thus we must manually handle the
`default: ZEND_UNREACHABLE();` case. Also add a comment indicating that for
future changes.
@marc-mabe
Use consistent type for h on call zend_hash_index_* (#19255)
f4d9ed1
@TimWolla
zend_compile: Use return true / return false for functions return…
19eabc6 
…ing `bool` (#21649)

Changes done with Coccinelle:

    @r1 exists@
    identifier fn;
    typedef bool;
    symbol false;
    symbol true;
    @@

    bool fn ( ... )
    {
    ...
    return
    (
    - 0
    + false
    |
    - 1
    + true
    )
    ;
    }
@pull pull bot locked and limited conversation to collaborators Apr 6, 2026
@pull pull bot added the ⤵️ pull label Apr 6, 2026
@pull pull bot merged commit 19eabc6 into turkdevops:master Apr 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

⤵️ pull

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TimWolla @LamentXU123 @marc-mabe