Create per-dataset hidden dashboard pages with stable nav links#7
Draft
Create per-dataset hidden dashboard pages with stable nav links#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
R/dataset_nav_pages.Rwithnew_dataset_page()to create stablenav_value/module_idpairs and a mutabledataset_namehandle, andreconcile_dataset_pages()to compute added/removed/renamed datasets.R/LightLogWeb-app.Rto dynamicallynav_insert()a hiddennav_panelper dataset,datasetDashboardServer()instantiation per page, andnav_remove()on deletion; navigation is driven bynav_select()using the selected dataset name.datasetDashboardServer()signature inR/m_dataset_dashboard.Rby removingactive_panelcoupling so the dashboard module can be instantiated per dataset page without changing its internal UI/content.tests/testthat/for the new page helpers, and addtestthattoDESCRIPTIONsuggests for CI.Testing
tests/testthat/test-dataset-nav-pages.Rcoveringnew_dataset_page()andreconcile_dataset_pages()semantics and a test for rename detection, and atests/testthat.Rtest runner was added.Rscript -e "testthat::test_dir('tests/testthat')"but execution failed in this environment becauseRscriptis not available; tests could not be executed here.Codex Task