Fix congested-port duplication to count distinct nets - #151
Draft
ShiboSoftwareDev wants to merge 1 commit into
Draft
Fix congested-port duplication to count distinct nets#151ShiboSoftwareDev wants to merge 1 commit into
ShiboSoftwareDev wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
TinyHyperGraphSolverassigns port ownership byNetId, so routes on the same net may legally share a port.DuplicateCongestedPortSolverinstead incremented its use count once per independently solved route. On BGA fanouts, multiple MST segments of one net could therefore manufacture unnecessary duplicate ports and inflate topology size.The regression uses two routes through the same choke. It fails before this change with
portUseCounts["shared-choke"] === 2and an extra port; with the fix, both routes map to one net owner and no duplicate is created. The existing two-distinct-net case still produces exactly one duplicate.Verification
bun test --timeout 9999999 tests/solver/duplicate-congested-port-solver.test.tsFull typechecking could not be reproduced in the linked checkout because the repository's Git-based benchmark datasets did not finish installing; the focused test compiles and passes.