Reproduce same-net duplicate port overcount - #141
Draft
ShiboSoftwareDev wants to merge 2 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
ShiboSoftwareDev
force-pushed
the
agent/repro-same-net-duplicate-port-overcount
branch
from
August 2, 2026 11:48
031e8f6 to
9f24144
Compare
ShiboSoftwareDev
force-pushed
the
agent/repro-same-net-duplicate-port-overcount
branch
from
August 2, 2026 11:50
9f24144 to
4dc738e
Compare
ShiboSoftwareDev
force-pushed
the
agent/repro-same-net-duplicate-port-overcount
branch
from
August 2, 2026 11:52
4dc738e to
2441693
Compare
ShiboSoftwareDev
force-pushed
the
agent/repro-same-net-duplicate-port-overcount
branch
from
August 2, 2026 11:55
2441693 to
76cb184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The core pathing solver reserves ports by electrical net, so branches of the same net may share a port.
DuplicateCongestedPortSolverinstead counts every route that uses a port. Two branches of one net are therefore treated like two competing nets and an unnecessary physical lane is created.Reproduction
This test reuses the repository's existing
sameNetSharedBottleneckFixture:route-aandroute-bboth belong tonet-0.shared-xbottleneck port.How to read the snapshot:
net: 0on hover.The second center port in the lower frame is the bug. The assertion expects one net use and no duplicate, so the reproduction fails with
Expected: 1, Received: 2on GitHub Actions.Stack
Stacked on #140. The fix is #142.