fix: snap same-net parallel trace segments to unified coordinates#410
Open
khozakhulile27-netizen wants to merge 22 commits into
Open
fix: snap same-net parallel trace segments to unified coordinates#410khozakhulile27-netizen wants to merge 22 commits into
khozakhulile27-netizen wants to merge 22 commits into
Conversation
Closes tscircuit#34 Adds a new `snapSameNetTraces` step to `TraceCleanupSolver` that detects parallel segments belonging to the same net that are within a configurable threshold (default 0.05) of each other and snaps them to their midpoint coordinate, eliminating near-coincident same-net trace lines. - New file: lib/solvers/TraceCleanupSolver/snapSameNetTraces.ts - Modified: TraceCleanupSolver pipeline adds `snapping_same_net` step after `balancing_l_shapes` - New file: tests/solvers/TraceCleanupSolver/snapSameNetTraces.test.ts (7 unit tests)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
khozakhulile27-netizen
changed the title
Author
|
"Hi everyone! 👋 |
Author
|
Hi, I have rebased my PR onto the latest upstream/main and verified that my branch is clean and fully up to date. I've also pushed an empty commit to trigger a status refresh. All tests are passing and the code is ready for final review. Thank you!" |
Author
khozakhulile27-netizen
left a comment
khozakhulile27-netizen
left a comment
There was a problem hiding this comment.
I fix everything am ready for merge
Author
khozakhulile27-netizen
left a comment
khozakhulile27-netizen
left a comment
There was a problem hiding this comment.
revert: restore last stable state to fix broken tests
khozakhulile27-netizen
force-pushed
the
fix/snap-same-net-parallel-traces
branch
from
c946455 to
261baf4
Compare
…m/khozakhulile27-netizen/schematic-trace-solver into fix/snap-same-net-parallel-traces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29. Fixes #34.
Implements a new
TraceCleanupSolverphase that snaps same-net parallel trace segments onto unified coordinates, merging traces that are at nearly identical X or Y positions. This eliminates the redundant/duplicate trace lines shown in issues #29 and #34.Changes:
/claim #29
/claim #34