fix: apply objectLimit globally after filtering#220
Open
phanlehieu10 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #42
Summary
objectLimitonce across the combined post-filter object set instead of separately per object typeRoot cause
objectLimitwas enforced independently inside each object array instead of once across the combined filtered result set. That let the UI render more thanobjectLimittotal objects and made the limit warning bookkeeping inaccurate.Validation
npm installnpx bun test tests/objectLimit.test.tsnpx bun testnpm run buildAll passed locally.
Note
I know there are already other attempts/PRs on this issue. I'm submitting this implementation because it reproduces the same underlying bug on current
main, fixes it with focused regression coverage, and may still be useful for review/comparison.