specify fontFamily to filter fonts#282
Open
NotsayJustdo wants to merge 1 commit intotsayen:masterfrom
Open
Conversation
if many fonts in stylesheets, dom-to-image will download all fonts, it will cause some problems: 1. waiting long time to load all fonts 2. use large computer memories, maybe make the browser breakdown. I suggest to add fontFamily option for user, user can specify they use fontFamily, it will avoid that problems!
IDisposable
reviewed
May 21, 2019
IDisposable
left a comment
IDisposable
left a comment
There was a problem hiding this comment.
Interesting fix, but a breaking change as it will not add a rule that sets multiple properties and a font-face... so some styling that might be applied/overridden will be lost.
| for (let i = 0; domtoimage.impl.options.fontFamily[i]; i++) { | ||
| if (rule.cssText.indexOf(domtoimage.impl.options.fontFamily[i]) !== -1) { | ||
| flag = true | ||
| break |
There was a problem hiding this comment.
nitpick code style of this repository requires trailing ;
|
|
||
| function copyOptions(options) { | ||
| // get user specifiy fontFamily | ||
| domtoimage.impl.options.fontFamily = options.fontFamily || [] |
There was a problem hiding this comment.
Should alias this to a local var to reduce double-dotting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, if many fonts in stylesheets, dom-to-image will download all fonts, it will cause some problems: 1. waiting long time to load all fonts 2. use large computer memories, maybe make the browser breakdown. I suggest to add fontFamily option for user, user can specify they use fontFamily, it will avoid that problems!