support keyless auth for rr blob storage#340
Open
JatinNanda wants to merge 1 commit into
Open
Conversation
renders RR_DEFAULT_AZURE_ACCOUNT_URL when rr.blobStorage.azure.accountUrl is set with no connection string, so azure can authenticate via managed identity (DefaultAzureCredential) instead of a static connection string. s3 and gcs keyless auth already work: the chart renders credentials only when set, and the pod uses serviceAccount.annotations for its identity (eks irsa / gke workload identity). this documents that and adds the azure account-url path that the backend now understands. connection string still takes precedence over accountUrl when both are set, matching the backend.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
adds keyless auth support for rr blob storage so deployments can authenticate as the pod's own cloud identity instead of a static credential. pairs with tryretool/retool_development#80111, which makes the backend accept keyless auth.
rr.blobStorage.azure.accountUrl. when set with no connection string, the chart rendersRR_DEFAULT_AZURE_ACCOUNT_URLand the backend authenticates viaDefaultAzureCredential(managed identity / azure workload identity). connection string still wins when both are set.to use keyless auth, omit the static credential and set
serviceAccount.annotationsso the pod carries the right identity:eks.amazonaws.com/role-arn(irsa), or an instance/ecs roleiam.gke.io/gcp-service-account(workload identity)azure.workload.identity/client-id+ theazure.workload.identity/use: "true"pod labeltest
helm templatewithazure: { container, accountUrl }rendersRR_DEFAULT_AZURE_ACCOUNT_URLand no connection string env.accountUrlandconnectionStringset, onlyRR_DEFAULT_AZURE_CONNECTION_STRINGis rendered (precedence matches backend).helm lintpasses.chart version bumped 6.11.5 -> 6.11.6.