Skip to content

Make All Documents accessible to VoiceOver on macOS - #656

Merged
trypsynth merged 1 commit into
trypsynth:masterfrom
johanntan:fix/macos-all-documents-accessibility
Aug 22, 2026
Merged

Make All Documents accessible to VoiceOver on macOS#656
trypsynth merged 1 commit into
trypsynth:masterfrom
johanntan:fix/macos-all-documents-accessibility

Conversation

@johanntan

Copy link
Copy Markdown
Contributor

Summary

  • use DataViewListCtrl for the All Documents table on macOS so VoiceOver can read its rows and columns
  • preserve the existing ListCtrl implementation on Windows and Linux
  • keep selection, activation, filtering, removal, focus, scrolling, and select-all behavior across both controls
  • update wxDragon to the revision containing the safe data-view APIs from Expose DataViewListCtrl selection and visibility helpers AllenDang/wxDragon#204

Motivation

The Table of Contents and Elements dialogs already use native data-view controls on macOS for VoiceOver accessibility. All Documents still used ListCtrl, which VoiceOver did not expose as a readable table.

Validation

  • manually tested the All Documents table with VoiceOver on macOS
  • cargo fmt --check
  • cargo check -p paperback --locked
  • cargo test -p paperback (40 passed)
  • cargo build -p paperback

@johanntan
johanntan marked this pull request as ready for review August 22, 2026 04:01
@trypsynth
trypsynth merged commit e139688 into trypsynth:master Aug 22, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants