Add property page accessible role for settings tabs and name for document tabs#554
Open
LeonarddeR wants to merge 1 commit into
Open
Add property page accessible role for settings tabs and name for document tabs#554LeonarddeR wants to merge 1 commit into
LeonarddeR wants to merge 1 commit into
Conversation
Owner
|
@LeonarddeR Thanks for this! Some thoughts:
Can you please try upstreaming this into wxDragon instead? I did this for macOS after I confirmed my implementation of labeling combo boxes and it got accepted. Slightly more work, but worth it in the long run IMO
I'll have to try this out to see how much it annoys me, I might end up voting for making that configurable or finding a different way to do it, but time will tell on that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accessibilitymodule exposingAccProps/AccessibleExtfor setting accessible name/role on any wxdragon widgetROLE_PROPERTYPAGE+ the tab's title as accessible name on the three Options dialog tab panels, so screen readers announce them as pages on Ctrl+TabNote that this only works on Windows, I'm too unfamiliar with Mac to see what might need changing there.
Also this slightly increases verbosity on the edit control because it mentions the title.