feat(framework-editor): requirement edit dialog context + row highlight (FRAME-7)#3124
Merged
Merged
Conversation
…hlight row When editing a requirement description in the large multi-line editor, the dialog said only "Edit Requirement Description" with no indication of which requirement was being edited, and the underlying row wasn't highlighted. - Append the requirement's identifier and name to the dialog title, e.g. "Edit Requirement Description - SC-13 - Cryptographic Protection". - EditableCell now reports open/close via onExpandedChange so the page can highlight the row whose editor is open (visible through the 50% overlay). Closes FRAME-7 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Linked issue analysis
Linked issue: FRAME-7: Framework Editor -> Edit requirement description needs identifier, name
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Dialog title includes identifier + name in the format 'Edit Requirement Description - - ' (falls back to plain title when empty) | The PR builds a titleSuffix from identifier and name and uses it in expandTitle; the page test was updated to assert the new dynamic title. |
| ✅ | The row being edited is visually highlighted while the multi-line editor dialog is open | The page tracks expandedRowId and conditionally adds ring + tinted background classes to the corresponding row while the editor is open. |
| ✅ | EditableCell notifies parent when the large editor opens/closes via an onExpandedChange callback | EditableCell exposes onExpandedChange, consolidates open/close through setExpanded which calls the callback, and Dialog onOpenChange is wired to it. Tests verify onExpandedChange(true/false) on open, Save, and Cancel. |
Contributor
|
🎉 This PR is included in version 3.82.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small UX fixes for the requirement description multi-line editor in the Framework Editor.
Why (FRAME-7)
When you open the large editor for a requirement description:
Changes
Edit Requirement Description - SC-13 - Cryptographic Protection(exactly the format Joe asked for). Falls back to plainEdit Requirement Descriptionif both are empty.EditableCellreports open/close via a newonExpandedChangecallback, soFrameworkRequirementsClientPagehighlights the active row. The editor dialog overlay isbg-black/50, so the row stays visible behind it — the highlight (ring+ tint) makes it obvious.Testing
EditableCell.test.tsx: added 2 tests —onExpandedChange(true)on open,(false)on Save and on Cancel. 12 tests pass.FrameworkRequirementsClientPage.expandable.test.tsx: updated the title assertion to the new dynamic value. Passes.npx turbo run typecheck --filter=@trycompai/framework-editor: clean.Frontend-only; no API or DB changes.
🤖 Generated with Claude Code
Summary by cubic
Adds requirement context to the multi-line description editor and highlights the active row while the dialog is open. Satisfies FRAME-7 by making it clear which requirement you’re editing.
EditableCellexposesonExpandedChange; the page highlights the active row (ring + tint) while the large editor is open, visible through thebg-black/50overlay.Written for commit f04e60d. Summary will update on new commits.