Conversation
…d results
A cloud scan that errored on every scope/unit silently returned [], which was
stored as a fresh status:'success' run with 0 findings. The UI shows only the
latest run per connection, so the empty run hid the previous good results
("0 total — Looking good"). This is what a customer hit on GCP after a scan.
GCP: scanSecurityFindings swallowed every per-scope SCC error and returned [].
Add an all-scopes-failed guard mirroring AWS (aws-security.service.ts:396-405):
track successful/failed scopes and re-throw the underlying SCC error when every
scope failed. A thrown scan skips storeFindings, so the prior good run stays
visible and the actionable error (SCC_NOT_ACTIVATED / PERMISSION_DENIED) finally
reaches the UI. A scope that succeeds with 0 findings does not throw.
Azure: same class of bug, no guard at all. A non-403 total failure (transient
500s / throttling) returned []. Refactor scanDefender to report whether any
query succeeded, and throw when the result is empty AND a unit failed — a clean
subscription still emits passing findings, so empty+failure is the real tell.
403 permission-findings and genuinely-empty subscriptions are unaffected.
AWS already handles this (regional all-failed guard, always active because
baseline regional services are always scanned) — verified, left unchanged.
Tests: +4 GCP, +4 Azure (new azure-security.service.spec.ts).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ACTIVATED error Verified in prod logs: the customer's project-scoped SCC query fails with 404 "Requested entity was not found" — their GCP account has no organization and SCC was never activated for the selected project. Without this mapping the new throw-guard would surface a raw "GCP API error (404)"; with it the user gets the existing SCC_NOT_ACTIVATED flow (400 + persistent inline error with the activation link). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ults-disappear fix(cloud-security): don't let a fully-failed GCP/Azure scan wipe good results
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.78.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Prevent GCP and Azure scans from saving empty “success” runs when every scope/unit fails, keeping previous results visible and surfacing actionable errors. Also map GCP SCC 404 responses to the SCC_NOT_ACTIVATED error.
Written for commit 83c24cd. Summary will update on new commits.