Conversation
… is bypassed
Trust Portal access auto-granted via the allow list (allowedDomains /
allowedEmails) bypasses NDA signing, but the "Access Granted" confirmation
email still rendered NDA-signed copy ("Your NDA has been signed", "download
your signed NDA"). Both the bypass path (approveWithoutNda) and the signing
path (signNda) call the same sendAccessGrantedEmail, so bypassed recipients
saw wording about an NDA they never signed.
Add an optional `ndaBypassed` flag threaded from the call sites through
sendAccessGrantedEmail into the AccessGrantedEmail template, which omits the
NDA sentences when set. approveWithoutNda passes true, signNda passes false,
and resendAccessGrantEmail derives it from the grant's linked NDA agreement
(grant.ndaAgreement?.status !== 'signed').
Tests: template render tests for both copy variants, plus service-level tests
asserting the flag on all three call sites (bypass, resend, signNda).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…-email fix(trust-portal): use NDA-free copy in access-granted email when NDA is bypassed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
🎉 This PR is included in version 3.78.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Fixes the Trust Portal “Access Granted” email so NDA wording only appears when an NDA was actually signed. Prevents confusing copy for allow‑list bypasses and aligns resend behavior.
ndaBypassedprop to hide NDA sentences when true.ndaBypassedintosendAccessGrantedEmail.approveWithoutNdasendsndaBypassed: true;signNdasendsfalse;resendAccessGrantEmailderives it fromndaAgreement?.status !== 'signed'.Written for commit dd38195. Summary will update on new commits.