Conversation
Adds a new "Account Types" evidence document type so it can be linked to NIST SP 800-53 controls in the framework editor. The form is a table of [Account Type, Allowed/Disallowed, Justification] pre-seeded with the 10 standard account types. This required two small, reusable additions to the evidence-form platform: - matrix columns can now be dropdown picklists (type: 'select' + options), not just free text; - matrix fields can ship default/seed rows. Conditional validation: a Justification is required only when a row is Allowed; Disallowed rows may leave it blank. Touch points (the current — code-only — way to add a document type): - EvidenceFormType enum + migration (packages/db) - @trycompai/company: form-types, db-form-type-map, types, definitions, submission-schemas - app wizard renders select columns + seeded rows (MatrixCellControl) - framework-editor DOCUMENT_TYPE_OPTIONS + app DOCUMENT_TYPE_LABELS Tests: 8 definition/validation specs + 1 wizard render spec (10 seeded rows, Allowed/Disallowed dropdowns, prefilled values). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… org scores The org-wide documents-progress scorers (taskEvidenceDocumentsScore + frameworks-scores.helper) count every !hidden && !optional form as an expected document for all orgs. Account Types is NIST-specific, so without this flag it would add an unsubmitted "outstanding" document to every org and lower their documents score. optional: true keeps it out of that global count while leaving it fully available in the documents UI and linkable to controls; per-control scoring counts it for any control it is linked to (it reads the control's linked types, not this flag). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…wse list Account Types is NIST-specific. hidden: true keeps it out of every org's Documents browse list (so non-NIST customers never see it); optional: true keeps it out of the org-wide expected-documents score. It stays fully usable where it matters: CS links it to a control in the Framework Editor, and the customer reaches and submits it from that control's Documents tab (the form route and per-control scoring use the linked types, not these flags). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…cument feat(evidence-forms): add Account Types document type (CS-513)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
The Controls grid initialized its sort state to [] (no sort), so it opened in arbitrary creation order and reset on every tab switch (the grid remounts per tab). Default the sort to the Name column ascending so it always opens A-Z, matching the Requirements tab's existing default-sort behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-name-sort fix(framework-editor): default Controls tab to Name A-Z sort (CS-511)
…b (CS-512) Controls are internal and reused across frameworks, so a per-control family makes no sense on the Controls tab (the family concept lives on Requirements). Removes the Control Family column plus the now-orphaned Manage Families button, dialog, and useFamiliesManagement hook (all exclusively served that column). The controlFamily field is left intact in the grid data and create/update payloads, so existing values are preserved and nothing downstream breaks; it is simply no longer shown or editable on this tab. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…amily-column feat(framework-editor): remove Control Family column from Controls tab (CS-512)
Contributor
|
🎉 This PR is included in version 3.77.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Add the
account-typesevidence form for NIST SP 800-53 (CS-513), extend the wizard for select-based matrix columns and seeded rows, remove the Control Family UI from the Controls tab (CS-512), and default that tab to Name A–Z (CS-511). Requires a standard DB migration (new enum value).New Features
account-typesform: matrix of Account Type / Allowed–Disallowed / Justification with 10 seeded rows; hidden and optional so it doesn’t affect global lists or org scores. Conditional validation: justification is required only when status is Allowed.type: 'select'with options anddefaultRowsvia aMatrixCellControl.packages/db,@trycompai/company, and app UIs.Bug Fixes
Written for commit c78c996. Summary will update on new commits.