Conversation
…ntrols A control created from a framework's Controls tab was created as a global template with no link to the framework, while the tab only lists controls linked to the framework's requirements — so committed controls silently vanished on the next visit. Uncommitted grid rows were also discarded without warning on tab navigation, and rows that failed (or were skipped for a missing name) stayed in the grid looking committed. - RelationalCell: allow picking links on uncommitted rows (opt-in allowSelectOnNewRows); both grids persist those links on commit - controls grid: on a framework tab, block committing a control with zero requirement links with an actionable error instead of letting it vanish - framework tab: requirement picker on new control rows is scoped to the framework's own requirements - both grids: empty-name rows now produce a commit error instead of being silently skipped; fully-successful commits router.refresh() to re-sync - FrameworkTabs + beforeunload: confirm before discarding uncommitted rows - AddExistingItemDialog: surface the API's real error message (e.g. "Framework has no requirements to link the control to") - add vitest setup for framework-editor + 15 unit tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Next's build-time typecheck on Vercel resolves two vite copies (root vs vitest's bundled one), making the plugin's Plugin type incompatible with vitest's defineConfig. esbuild already handles TSX for tests, so the plugin was only adding the type conflict. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-link-blocker fix(framework-editor): prevent silent loss of new requirements and controls
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 3.74.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by cubic
Prevents new controls and requirements from “vanishing” in the Framework Editor by enforcing required links on framework tabs, preserving link selections on commit, and warning before leaving with unsaved changes.
Bug Fixes
router.refresh().New Features
allowSelectOnNewRowslets users pick links on new rows; links are saved on commit (used for requirements on the Controls tab and controls on the Requirements tab).FrameworkTabsprevents accidental loss of uncommitted rows.Written for commit 5f64e6f. Summary will update on new commits.