Conversation
…account
Customer connected 3 AWS accounts; the "S3 — default encryption enabled" check
showed 31 buckets with no indication of which account each belongs to, and it
was unclear how the other accounts are covered. Checks already run per
connection (1 AWS account = 1 connection), so all accounts ARE scanned — but the
account was never surfaced in the findings, so the UI shows a merged, unlabeled
list.
All six AWS checks (s3, cloudtrail, ec2, iam, kms, rds) emit through the shared
emitOutcomes(), so stamp the account there in one place: derive the 12-digit
account id from the connection's roleArn (awsAccountIdFromCtx, moved to shared)
and add it to every finding's evidence (awsAccountId) and visible description
("… (AWS account 123456789012)"). No schema/API/UI/migration needed — the
account now shows per result regardless of how the UI groups them, which also
makes it clear all connected accounts are covered.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ongside the account Build on the account-attribution stamp: when the customer named the connection (the "Connection Name" field, e.g. "Production AWS" — stored in credentials and mirrored to connection.metadata), surface that real label too. The finding description becomes "… (AWS account 123456789012 — Production AWS)" and evidence gains awsConnectionName. This is the customer's OWN label — we do not infer prod/stage from AWS (no reliable signal); falls back to the account id alone when no name is set. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ibution fix(integration-platform): attribute AWS check findings to their AWS account (multi-account)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
🎉 This PR is included in version 3.74.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Make AWS check findings clearly show which account they belong to. Each result now includes the 12-digit AWS account ID and, if set, the connection’s name (e.g. “Production AWS”) in both the description and evidence.
emitOutcomes: stampsawsAccountIdfromcredentials.roleArnand optionalawsConnectionName, and appends “(AWS account … — …)” to descriptions.awsAccountIdFromCtx(moved toshared.ts); updated S3 checks to use it.Written for commit 84b63e0. Summary will update on new commits.