Conversation
…verflow The Connection Settings modal renders one tab per connected account via the design-system TabsList, which is `inline-flex w-fit`. With more than ~3 accounts the strip grows wider than the dialog and gets clipped by DialogContent's `overflow-hidden`, leaving the extra accounts unreachable (a customer with 6 AWS accounts could only see/select the first few). TabsList already has `overflow-x-auto` but it never triggers because `w-fit` sizes it to its content, so it overflows its parent instead of scrolling within itself — and TabsList doesn't accept `className`. Wrap it in a width-constrained `overflow-x-auto` container so the strip scrolls horizontally and every account stays reachable. Pure presentational change; no DS internals or imports touched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…settings-overflow fix(cloud-tests): scroll connection-settings account tabs when they overflow
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
🎉 This PR is included in version 3.73.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Fix the account tabs overflow in the Cloud Settings modal so all connected accounts are reachable. Wraps the
TabsListin a full-width, horizontally scrollable container to prevent clipping inside the dialog.Written for commit bb4f8a0. Summary will update on new commits.