Skip to content

CS-218 [Improvement] - Ability to log findings within the People section#2487

Open
github-actions[bot] wants to merge 35 commits intomainfrom
chas/people-findings
Open

CS-218 [Improvement] - Ability to log findings within the People section#2487
github-actions[bot] wants to merge 35 commits intomainfrom
chas/people-findings

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 8, 2026

This is an automated pull request to merge chas/people-findings into dev.
It was created by the [Auto Pull Request] action.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-framework-editor Ready Ready Preview, Comment Apr 10, 2026 6:58pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app Skipped Skipped Apr 10, 2026 6:58pm
portal Skipped Skipped Apr 10, 2026 6:58pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 8, 2026

PR Summary

Medium Risk
Adds a new nullable Finding.scope enum persisted via Prisma migration and threads it through creation, querying, and notification flows, which could affect data integrity and who receives emails/in-app alerts. Also introduces a new People Findings UI and filtering that depends on the new API query behavior.

Overview
Adds a new FindingScope concept (nullable Finding.scope) so findings can be created and queried for the People section, not just tasks/documents.

Updates the API to accept scope on create, log it in audit events, and support GET /v1/findings queries via scope or hasScope=true (with recipient/URL handling in FindingNotifierService that deep-links to /${orgId}/people?tab=findings and notifies owners/admins for scope-based findings).

Adds a new People "Findings" tab in the app with a scoped findings list (filtering, show-more, create via CreateFindingButton with scope selector, and history panel), and surfaces scope in existing finding UI via a FindingScopeBadge; overview findings now title/link correctly for scoped findings.

Reviewed by Cursor Bugbot for commit 8ce0969. Bugbot is set up for automated code reviews on this repo. Configure here.

@mintlify
Copy link
Copy Markdown
Contributor

mintlify bot commented Apr 8, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
CompAI 🟢 Ready View Preview Apr 8, 2026, 1:09 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@chasprowebdev chasprowebdev changed the title [dev] [chasprowebdev] chas/people-findings CS-218 [Improvement] - Ability to log findings within the People section Apr 8, 2026
@linear
Copy link
Copy Markdown

linear bot commented Apr 8, 2026

@vercel vercel bot temporarily deployed to Preview – portal April 10, 2026 17:58 Inactive
@chasprowebdev
Copy link
Copy Markdown
Contributor

Recording:

people-findings.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants