Open
Conversation
ccuetom
requested changes
Jul 30, 2025
| @@ -71,6 +72,39 @@ def plot_points_2d(coordinates, axis=None, colour='red', size=15, title=None, | |||
|
|
|||
|
|
|||
| def plot_points_3d(coordinates, axis=None, colour='red', size=15, title=None, **kwargs): | |||
Contributor
There was a problem hiding this comment.
could you change the name to plot_points_3d_matplotlib?
| ax.grid(True) | ||
| ax.set_box_aspect([1, 1, 0.5]) | ||
| plt.tight_layout() | ||
| plt.show() |
Contributor
There was a problem hiding this comment.
in all of these functions, we return the axis instead of plotting inside the function - remove these last two lines and change to return ax
| title : str, optional | ||
| Figure title, defaults to empty title. | ||
| """ | ||
| fig = plt.figure(figsize=(10, 8)) |
Contributor
There was a problem hiding this comment.
check how other matplotlib functions are written, where we let the user provide some external figure/axes and, if not, we create create ones
| Size of the plotted points, defaults to 15. | ||
| title : str, optional | ||
| Figure title, defaults to empty title. | ||
| """ |
Contributor
There was a problem hiding this comment.
check other matplotlib functions to add display test at top
| """ | ||
| fig = plt.figure(figsize=(10, 8)) | ||
| ax = fig.add_subplot(111, projection='3d') | ||
| ax.set_title('3D View: Tangent Points with Out-of-Plane Displacement') |
Contributor
There was a problem hiding this comment.
title should be provided externally as parameter, as done in other functions like this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes made to facilitate jobs. Improvement to findomp and a 3D geometry plotter that doesn't depend on mayavi