Skip to content

docs(flaky-tests): document slow test monitor percentile settings and events tab#126

Open
samgutentag wants to merge 1 commit into
mainfrom
sam-gutentag/slow-test-monitor-percentile-events
Open

docs(flaky-tests): document slow test monitor percentile settings and events tab#126
samgutentag wants to merge 1 commit into
mainfrom
sam-gutentag/slow-test-monitor-percentile-events

Conversation

@samgutentag
Copy link
Copy Markdown
Member

@samgutentag samgutentag commented May 28, 2026

Summary

  • Adds a Percentile setting to the configuration table, explaining how p50 vs p95 affect detection sensitivity (p50 is stricter -- requires more slow runs; p95 catches sporadic slowness).
  • Updates "How It Works" to say "percentile duration" instead of "average duration", which matches the actual implementation.
  • Notes that the threshold comparison uses >=, consistent with failure rate monitors (trunk-io/trunk2#4030).
  • Documents that slow-test detection evidence now appears in the Events tab on the test details page (trunk-io/trunk2#4024).
  • Adds the 1000-test preview cap to the Window and Sample Size section.

Covers: trunk-io/trunk2#4024 and trunk-io/trunk2#4030, shipped in v189.

Test plan

  • Verify prose renders correctly on Mintlify preview
  • Confirm percentile semantics match the slow-test-monitor-dialog.tsx UI labels
  • Check Events tab behavior matches description

Co-Authored-By: Claude noreply@anthropic.com

Generated by Claude Code

@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 28, 2026 •
edited
Loading

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
trunk 🟢 Ready View Preview May 28, 2026, 6:14 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@samgutentag Claude
Copy link
Copy Markdown
Member Author

samgutentag commented May 28, 2026 •
edited
Loading

Verification status (2026-05-29): live

Verified: customers can use this. Ready to publish.

  • Flag state: LaunchDarkly not consulted (no feature flag gates these changes).
  • Eng PR: trunk-io/trunk2#4024 (merged 2026-05-27), trunk-io/trunk2#4030 (merged 2026-05-27). Both merge commits intact on main.
  • Flag: none (ungated bug fixes and behavior changes).
  • Signals: both eng PRs merged to main; no feature flags found in PR bodies or diffs; changes are UI corrections and a query-operator fix with no rollout gate.

Mark ready and merge when docs review is complete.

@samgutentag samgutentag marked this pull request as ready for review May 28, 2026 18:14
@samgutentag samgutentag added the ready to merge Verify docs PR: customers can use this. Ready to publish. label May 28, 2026 — with Claude
@samgutentag Claude
Copy link
Copy Markdown
Member Author

samgutentag commented May 31, 2026

Verification status (May 31, 2026): live

Both eng PRs have merged; the slow-test monitor feature is in production.

  • Flag state: not consulted
  • Eng PRs: trunk2#4024 (merged), trunk2#4030 (merged)
  • Flag: none
  • Signals: feature fully shipped; docs are accurate as written

Next action: merge this PR.

Generated by Claude Code

@samgutentag Claude
Copy link
Copy Markdown
Member Author

samgutentag commented Jun 1, 2026 •
edited
Loading

Verification status (2026-06-01): live

Verified: customers can use this. Ready to publish.

  • Flag state: LaunchDarkly not consulted (no feature flag gates these changes; neither eng PR diff references useFeatureFlag/useFlag/LaunchDarkly).
  • Eng PRs: trunk-io/trunk2#4024 (merged 2026-05-27), trunk-io/trunk2#4030 (merged 2026-05-27). Both merge commits confirmed intact on main this sweep. Shipped in v189.
  • Flag: none (ungated UI corrections and a query-operator change).
  • Signals: both eng PRs merged to main, no rollout gate.

Unchanged from prior sweep: still live. PR is currently CONFLICTING (needs rebase); does not affect this verdict.

Generated by Claude Code

@claude @samgutentag
docs(flaky-tests): add percentile explanation and events tab note to …
8a25368 
…slow test monitor

Documents the percentile setting for the slow test monitor (p50 vs p95
semantics), updates detection threshold language to reflect the >= comparison,
adds the 1000-test preview cap, and notes that detection evidence now appears
in the Events tab on the test details page.

Covers trunk-io/trunk2#4024 and trunk-io/trunk2#4030 (shipped in v189).

Co-Authored-By: Claude <noreply@anthropic.com>
@samgutentag samgutentag force-pushed the sam-gutentag/slow-test-monitor-percentile-events branch from e52a769 to 8a25368 Compare June 1, 2026 20:32
@samgutentag Claude
Copy link
Copy Markdown
Member Author

samgutentag commented Jun 2, 2026

Verification status: live - June 2, 2026

Verified: customers can use this. Ready to publish.

  • Flag state: No feature flag found; QA fixes with no LD gate
  • Eng PR links: trunk-io/trunk2#4024 (merged 2026-05-27), trunk-io/trunk2#4030 (merged 2026-05-27)
  • Flag: none
  • Signals checked: trunk2 PR merge status; PR bodies confirm no LD flag
  • Suggested next action: Ready to merge as-is.

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready to merge Verify docs PR: customers can use this. Ready to publish.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samgutentag @claude