[INS-165] Jdbc detector integration tests fix#4637
Merged
MuneebUllahKhan222 merged 2 commits intotrufflesecurity:jdbc-detector-regex-fixfrom Jan 12, 2026
Conversation
MuneebUllahKhan222
changed the base branch from
main
to
jdbc-detector-regex-fix
kashifkhan0771
approved these changes
Jan 5, 2026
amanfcp
approved these changes
Jan 5, 2026
amanfcp
reviewed
Jan 5, 2026
nabeelalam
approved these changes
Jan 12, 2026
Contributor
nabeelalam
left a comment
nabeelalam
left a comment
There was a problem hiding this comment.
LGTM, just commit the suggested change above. Thanks!
MuneebUllahKhan222
merged commit 30b4660
into
trufflesecurity:jdbc-detector-regex-fix
11 checks passed
peterfraedrich
pushed a commit
to peterfraedrich/trufflehog
that referenced
this pull request
Mar 15, 2026
…d fixed invalid… (trufflesecurity#4636) * Fix jdbc detector detecting incomplete conn string and fixed invalid parsing of sql server string * [INS-165] Jdbc detector integration tests fix (trufflesecurity#4637) * [INS-165] Fix Jdbc tests and updated the deprecated code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Some of the integration test in jdbc detectors were not working, Also we were using deprecated functions from the packages.
This PR updated/removes the deprecated code.
Checklist:
make test-community)?make lintthis requires golangci-lint)?