Reduce false positives in Chatbot detector#4629
Open
rootranjan wants to merge 1 commit intotrufflesecurity:mainfrom
Open
Reduce false positives in Chatbot detector#4629rootranjan wants to merge 1 commit intotrufflesecurity:mainfrom
rootranjan wants to merge 1 commit intotrufflesecurity:mainfrom
Conversation
- Add filters to exclude letters-only matches (no digits) - Filter out snake_case patterns (variable/table names) - Filter out camelCase/PascalCase patterns (code identifiers) - Fix lint error by properly handling res.Body.Close() error This reduces false positives from legitimate code identifiers like variable names, class names, and schema names while still detecting real Chatbot API keys that contain digits and have higher entropy.
kashifkhan0771
requested changes
Jan 5, 2026
Contributor
kashifkhan0771
left a comment
There was a problem hiding this comment.
I’m not opposed to these changes - they look reasonable. However, they would need to be applied across many detectors. At the moment, we try to avoid modifying existing detectors unless there’s a high-priority issue.
We plan to add these validations as part of an upcoming feature, detectors as config, which will bring existing detectors closer to how custom_detector works. (Note that these validations already exist in custom_detector.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4628
Description:
Reduce false positives in Chatbot detector by filtering out legitimate code identifiers that match the detector pattern.
Changes:
This reduces false positives from legitimate code identifiers like variable names, class names, and schema names while still detecting real Chatbot API keys that contain digits and have higher entropy.
Problem:
The Chatbot detector was flagging any 32-character alphanumeric string near the keyword "chatbot" as a potential secret, including:
internalFeatureNavigationManager)analytics_abc_meltsys_adachatbot)Solution:
Added
isLikelyFalsePositive()helper function that filters out:^[a-z]+(_[a-z]+)+$) - Common for variable/table namesChecklist:
make test-community)?make lintthis requires golangci-lint)?