[INS-228] Add ignorePattern configuration support to Postgres and Sqlserver detectors#4612
Conversation
camgunz
left a comment
There was a problem hiding this comment.
I see that a couple other detectors have New methods, but I can't find where that's called. Do you know where that is?
Not really. My assumption was that enterprise calls it at some point, but I guess that's not the case? As mentioned in the description, I closely followed JDBC detector's implementation here, which also has this |
|
I found it; you're right it's in EE. |
camgunz
left a comment
There was a problem hiding this comment.
This looks good! I just want to make sure this works OK if we don't call .New, because that's a separate change we'll have to make in EE, so the change I'm requesting here is to add a couple tests where we don't call .New and things work OK.
I have added tests for SqlServer that don't call |
…ort-to-Postgres-and-SQLServer-detectors
…server detectors (trufflesecurity#4612) * add ignorePattern configuration support to postgres and sqlserver detectors * add test for sqlserver detector that doesn't use New
…server detectors (trufflesecurity#4612) * add ignorePattern configuration support to postgres and sqlserver detectors * add test for sqlserver detector that doesn't use New
Description:
This PR adds ignorePattern configuration support to the Postgres and Sqlserver detectors. It closely follows the implementation for JDBC detector
Checklist:
make test-community)?make lintthis requires golangci-lint)?