fix(thread): release multiple transferred roots under one visited set - #213
Merged
Conversation
A transfer deep-copies an object graph under one ctx whose xlat table dedups shared objects — a closure that captures an object transferred alongside it points at the same copy. Release dedups only WITHIN one async_thread_release_transferred_zval call (a fresh visited set each), so an embedder that stores several roots of one transfer and releases them separately freed a shared copy twice. Add async_thread_release_transferred_zvals(roots, n) — one visited set across all roots, freeing a shared object exactly once — and register it on the reactor's thread-pool API.
EdmondDantes
force-pushed
the
fix/batched-transferred-release
branch
from
July 28, 2026 21:06
f303b31 to
b5ea591
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transfer deep-copies an object graph under one ctx whose xlat table dedups shared objects (a closure capturing an object transferred beside it points at the same copy). Release dedups only WITHIN one
async_thread_release_transferred_zvalcall — a fresh visited set each — so an embedder that stores several roots of one transfer and releases them separately freed a shared copy twice (double-free; UAF at shutdown). Addsasync_thread_release_transferred_zvals(roots, n)— one visited set across all roots — and registers it. Needs the Zend-API addition (php-src PR). Repro'd + regressed by true-async/server.