feat(toolkit): monitor on SR votes #105
Open
warku123 wants to merge 11 commits intotronprotocol:developfrom
Open
feat(toolkit): monitor on SR votes #105warku123 wants to merge 11 commits intotronprotocol:developfrom
warku123 wants to merge 11 commits intotronprotocol:developfrom
Conversation
bladehan1
reviewed
Jan 4, 2026
|
|
||
| body, err := io.ReadAll(resp.Body) | ||
| if err != nil { | ||
| return "" |
Contributor
There was a problem hiding this comment.
It's better to handle error messages by writing them to logs.
Author
There was a problem hiding this comment.
Already add logs file in logs/sr_monitor.log
barbatos2011
reviewed
Jan 4, 2026
|
|
||
| go 1.25.5 | ||
|
|
||
| require github.com/joho/godotenv v1.5.1 |
There was a problem hiding this comment.
Please check the security of this package
Author
There was a problem hiding this comment.
This package is the de-facto standard for environment variable management in the Go community (10k+ Stars), repo: https://github.com/joho/godotenv. Its logic is minimal and transparent (reading local files only).
I've scanned the project using the official Go vulnerability tool govulncheck, and no vulnerabilities were detected in this package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an SR votes monitor and push the results to Slack channel
Why are these changes required?
To get SR votes information ontime
This PR has been tested by:
Follow up
Extra details