Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
actuator.whitelistconfiguration and all related code. All actuator types are now unconditionally registered and executed on every node. Nodes with the old config key inconfig.confare unaffected — it is silently ignored after upgrade.Why are these changes required?
actuator.whitelistwas designed for private-chain scenarios and is fundamentally incompatible with public-chain consensus. A node configured with a non-empty whitelist skips registering excluded actuator types at startup. When the network produces a block containing those transaction types, the configured node fails to execute them, its world state diverges from the network, and it forms a private fork. Removing this configuration eliminates the risk of consensus breakage caused by misconfiguration.This PR has been tested by:
TransactionRegisterTest,ParameterTest— all passcheckstyleMain,checkstyleTest— no violationsFollow up
None.
Extra details
TransactionRegister.registerActuator()was already updated in a prior PR to register all actuators unconditionally. This PR completes that cleanup by removing the whitelist enforcement that remained in the execution path (TransactionFactory,RuntimeImpl) and the associated config infrastructure (CommonParameter,Args,ConfigKey).