test(framework): stabilize test fixtures and fix resource leaks#6664
Closed
bladehan1 wants to merge 5 commits intotronprotocol:developfrom
Closed
test(framework): stabilize test fixtures and fix resource leaks#6664bladehan1 wants to merge 5 commits intotronprotocol:developfrom
bladehan1 wants to merge 5 commits intotronprotocol:developfrom
Conversation
change RocksDB iterator exception checks to use Assert.assertThrows for clearer intent and stricter failure behavior when expected exceptions are not thrown.
Consolidate the misplaced keystroe CredentialsTest into org.tron.keystore.CredentialsTest. - remove the duplicate test under the misspelled keystroe package - add explicit equals behavior coverage for address and cryptoEngine - normalize assertions to JUnit Assert and remove legacy TestCase usage
Replace random Credentials test setup with deterministic SignInterface mocks so the suite no longer depends on platform-specific SecureRandom providers or probabilistic retries. - remove NativePRNG usage from CredentialsTest - replace random key generation with fixed address fixtures via mocked SignInterface - assert create(SignInterface) returns the expected base58check address - keep equals/hashCode contract coverage with deterministic inputs
Collaborator
Author
|
only for Ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DBIteratorTestby properly closing iteratorsCredentialsTestcoverage fromkeystroe(typo package) intokeystoreCredentialsTestfixtures with dynamic temp file generationTest plan
./gradlew :framework:test --tests "org.tron.core.db.DBIteratorTest"./gradlew :framework:test --tests "org.tron.keystore.CredentialsTest"org.tron.keystroe.CredentialsTesthas no unique coverage🤖 Generated with Claude Code