Fix similar(::ThreadedBroadcastArray, dims)

[efaulhaber]

main:

julia> x = TrixiParticles.ThreadedBroadcastArray(ones(1))
1-element TrixiParticles.ThreadedBroadcastArray{Float64, 1, Vector{Float64}, PolyesterBackend}:
 1.0

julia> y = similar(x, 2)
2-element Vector{Float64}:
 2.3117208883e-314
 2.2158487935e-314

This PR:

julia> y = similar(x, 2)
2-element TrixiParticles.ThreadedBroadcastArray{Float64, 1, Vector{Float64}, PolyesterBackend}:
 1.52e-321
 1.527e-321

This is currently used in the SplitIntegrationCallback:

TrixiParticles.jl/src/callbacks/split_integration.jl

Lines 111 to 112 in 0acb886

	v0_ode_split = similar(v_ode, sum(sizes_v))
	u0_ode_split = similar(u_ode, sum(sizes_u))

[Copilot]

Pull request overview

This PR fixes a bug in the similar method for ThreadedBroadcastArray where calling similar(array, dims) would incorrectly return a plain Vector instead of a ThreadedBroadcastArray. This issue affected code in SplitIntegrationCallback that uses similar(v_ode, sum(sizes_v)) to create arrays with different dimensions.

Changes:

• Updated Base.similar signature to include dims parameter, making it properly support dimension changes
• Added comprehensive tests for various similar call patterns

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/util.jl	Updated Base.similar method signature to accept dims::Base.Dims parameter and forward it to the underlying array
test/general/util.jl	Added tests verifying that similar returns correct types for various argument patterns

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.46%. Comparing base (c853d65) to head (9ab66dd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1078   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         126      126           
  Lines        9657     9657           
=======================================
  Hits         8640     8640           
  Misses       1017     1017           

Flag	Coverage Δ
total	89.46% <100.00%> (ø)
unit	67.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[svchb]

/run-gpu-tests

[svchb]

/run-gpu-tests