Remove template parameter Archive from InputBindingsMap and `Outp…#1
Merged
alexisji merged 1 commit intotripoli5-deps:masterfrom Feb 19, 2026
Merged
Conversation
…utBindingsMap` `Archive` isn't directly needed for any content in binding structs and required only to instantiate different global static maps for different archives. This commit turns `InputBindingsMap` and `OutputBindingsMap` into non-templated structs and modifies binding maps to include archive's typeid, such that they describe relation: `typeid(Archive) -> per-archive binding map`. That way only two global static objects will be created in runtime (for input and output bindings respectively) in each library/executable. Also types of these globals are independent from included archives and known beforehand.
|
Looks good to me. Do we want to merge to the master? or to another branch to keep the master in line with the upstream? |
Author
|
Our master is already 4 commits ahead of the upstream, so I'm not sure it matters too much now. I think we can just merge it into our master and continue that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modification was originally proposed on #812 on the upstream, but there hasn't been any activity there in quite a while. I think it is worthwhile to merge this one into our fork.