Replace EOL PyPy 3.9/3.10 with PyPy 3.11 in CI matrix#607
Open
srchilukoori wants to merge 1 commit into
Open
Conversation
srchilukoori
force-pushed
the
fix/pypy-3.11-ci
branch
from
8f318c5 to
69af35d
Compare
1 task
srchilukoori
force-pushed
the
fix/pypy-3.11-ci
branch
from
69af35d to
dd3f4c6
Compare
hashhar
reviewed
Jun 15, 2026
hashhar
reviewed
Jun 15, 2026
hashhar
left a comment
hashhar
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. One question which I maybe didn't understand properly.
Fix gssapi (CPython-only) at the CI/packaging layer instead of scattering conditional guards through test code: - Remove gssapi_require from tests_require so .[tests] is installable on PyPy without pulling CPython-only C extensions. - Conditionally install .[tests,gssapi] on CPython, .[tests] on PyPy. - Extract pure gssapi tests to test_auth_gssapi.py with pytest.importorskip for clean module-level skip. - Guard kerberos/gssapi imports in test_client.py with try/except and pytest.mark.skipif for the shared retry test. Fixes trinodb#606
srchilukoori
force-pushed
the
fix/pypy-3.11-ci
branch
from
dd3f4c6 to
e5b7f53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pypy-3.9/pypy-3.10withpypy-3.11in CI matrixgssapiextra on PyPy — the C extension is CPython-onlygssapi_requirefromtests_requireso extras are composabletest_auth_gssapi.pywithpytest.importorskipFixes #606
Problem
Two issues broke PyPy CI:
cryptography>= 47.0.0 dropped pre-built wheels for PyPy < 3.11. Without a wheel, pip builds from source and fails because PyO3 0.28.3 requires PyPy >= 3.11. Dependency chain:keyring→SecretStorage→cryptography.gssapiis CPython-only. On PyPy 3.9 a cached pre-built wheel happened to work. On PyPy 3.11 it builds from source and produces a.soreferencing_PyGC_FINALIZED— a CPython internal not present in PyPy:Root cause
The CI install step and
setup.pyboth assumed gssapi is universally installable.tests_requirebundledgssapi_require, so evenpip install .[tests]pulled CPython-only C extensions on PyPy.Fix
setup.pygssapi_requirefromtests_require—.[tests]should not pull CPython-only depsci.yml.[tests,gssapi]on CPython,.[tests]on PyPytest_client.pypytest.param(..., marks=requires_gssapi)for the sharedtest_authentication_fail_retrytest_auth_gssapi.py(new)pytest.importorskip("gssapi")— entire module skips cleanly on PyPyOn CPython with
.[tests,gssapi], all tests run as before. On PyPy with.[tests], gssapi tests skip with a clear reason.Test plan
CI
build (pypy-3.11, latest, ~=1.4.0)passes with gssapi tests skippedAll CPython matrix jobs pass with full gssapi test coverage
Verified locally:
test_client.py— 46 passed, 2 skipped;test_auth_gssapi.py— 1 skipped (module-level importorskip)Yes, this is an AI-assisted PR.