perf(webapp,run-store): grouped run-ops reads + mint-kind flip grace#4227
Draft
d-cs wants to merge 20 commits into
Draft
perf(webapp,run-store): grouped run-ops reads + mint-kind flip grace#4227d-cs wants to merge 20 commits into
d-cs wants to merge 20 commits into
Conversation
Several run-ops read paths issued one database query per item where a single batched query returns the same data: batch results hydrated each member run separately, the run retrieve endpoint resolved each locked worker version separately, the dedicated-schema relation hydrator ran per row, and a few services read runs in per-id loops. These now group into batched reads. Adds a grouped findRunsByIds to the run store (one residency-partitioned read for a set of run ids) and routes the presenters and services through it. The dedicated-schema relation hydrator batches across all rows per relation. The waitpoint connected-runs read also regains its display limit at the fetch, so it no longer loads every connected run into memory before slicing to five.
…n unrequested findRunsByIds forces `id` into the select so it can key the result map, but did not remove it afterwards, so returned rows carried an `id` the declared payload type did not include. Delete the injected id from each value when the caller's select did not request it; the map stays keyed by id.
…list The waitpoint detail view capped the connected-run lookup before checking the runs still existed, so a run deleted after connecting could take a slot ahead of a live one and under-count (or empty) the list. Join to the run table so the cap only ever lands on connections whose run still exists.
Batched relation hydration returned the same row object to every parent linking the same target, so two parents connected to one run shared a single instance and an in-place edit to one leaked into the other. Return a shallow clone on the bare-projection path so each parent gets a distinct object.
The connected-runs relation read fetched every connection id for a waitpoint with no existence check or limit, so a heavily-connected waitpoint could pull an unbounded id list into the grouped run lookup. Existence-join to the run table and cap at the shared connected-runs limit on both schema branches, and slice the cross-store union to the same bound.
The dedicated-schema relation hydrators fetched full target rows and then stripped unrequested fields in memory, pulling wide columns even when the caller only selected a couple. Push the caller's select into the target findMany so only the requested columns are read. No change to results.
Flipping an organization's run-ops mint kind (which database new runs are minted on) took effect independently per process as each cached value expired. For a window after a flip, two concurrent triggers using the same idempotency key could mint on different databases, where the per-database unique constraint can't dedupe them, producing a duplicate run. The flip is now a deterministic wall-clock cutover: the admin feature-flag routes stamp the previously-effective kind and a flip timestamp onto the organization, and the mint read resolves the old kind until flippedAt + grace (default 90s, chosen to outlast the caches a flip drains through), after which every process crosses to the new kind together. During the window all processes agree on one database, so a concurrent same-key collision lands on a single database and the existing unique-constraint retry returns the one idempotent run. A same-target re-save carries the in-flight stamp forward, so it can't slide the cutover.
…clock The grace-window cutover was timestamped with the webapp process's own clock, so clock skew between processes could shift the boundary. Read the time from the control-plane database instead, so the flip is anchored to one authoritative clock rather than whichever process handled the flag change.
The grace cutover compares the reader's wall clock against a DB-clock flippedAt stamp, so it assumes clock-synced hosts (skew well under the grace window). Records that invariant and the accepted residual on effectiveMintKind. No behavior change.
Global runOpsMintKind flips now stamp the previous kind and flip time like per-org flips, so a global flip is a deterministic cutover and cannot route two concurrent triggers that share an idempotency key to different databases. The resolver reads the grace stamp from the same source as the kind.
…isses RoutingRunStore.findRun routed a classifiable id to its single owning store by id shape and returned null on a miss, so a run whose physical residency diverges from its id shape would 404 even though it exists. Read the owning store first, then fall back to the other store only on a miss, mirroring the unrouted fan-out. The found-in-owning-store path is unchanged (single read).
|
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds deterministic mint-flip grace metadata, stamping, and cache resolution. Introduces grouped control-plane and run-store lookups, batched relation hydration, residency fallbacks, projection isolation, and connected-run query limits. Updates presenters to use grouped split-store reads and adds integration coverage for batching, split schemas, routing, schedules, and cross-database waitpoint resumption. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.ts (1)
116-136: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winMerge existing org flags before stamping mint kind
This handler writes
validationResult.datadirectly, so any partial save replaces the whole org blob and can also forcerunOpsMintKindtocuidviastampMintKindFlipwhen that field is omitted. That can silently drop unrelated flags and opt the org out of future global mint-kind flips; merge against the current org flags first, or skip mint stamping unlessrunOpsMintKindwas part of the edit.
🧹 Nitpick comments (4)
apps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.ts (2)
1-4: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCo-locate this test with its presenter.
Move this test beside
ApiRetrieveRunPresenter.server.tsrather than keeping it underapps/webapp/test/. As per coding guidelines,**/*.test.{ts,tsx,js,jsx}test files must be placed next to their source files.Source: Coding guidelines
136-145: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse a type alias for this data shape.
Proposed fix
-interface SeedRunOpts { +type SeedRunOpts = { id: string; friendlyId: string; runtimeEnvironmentId: string; projectId: string; organizationId: string; lockedToVersionId?: string; parentTaskRunId?: string; rootTaskRunId?: string; -} +};Source: Coding guidelines
apps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.ts (1)
1-13: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCo-locate this test with
ApiBatchResultsPresenter.This
*.test.tsfile belongs beside its source presenter, not underapps/webapp/test/. As per coding guidelines,**/*.test.{ts,tsx,js,jsx}test files must be placed next to their source files.Source: Coding guidelines
apps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.ts (1)
1-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCo-locate this test with
ApiBatchResultsPresenter.Place this
*.test.tsfile next to the presenter it covers. As per coding guidelines,**/*.test.{ts,tsx,js,jsx}test files must be placed next to their source files.Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a5e07a0e-15ea-41f7-8091-5374cdb7a5bb
📒 Files selected for processing (32)
apps/webapp/app/env.server.tsapps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.tsapps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.tsapps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/routes/admin.api.v1.feature-flags.tsapps/webapp/app/routes/admin.api.v1.orgs.$organizationId.feature-flags.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/featureFlags.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.test.tsapps/webapp/app/v3/runOpsMigration/controlPlaneResolver.server.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.tsapps/webapp/app/v3/runOpsMigration/runOpsMintKind.flipLatency.test.tsapps/webapp/app/v3/runOpsMigration/runOpsMintKind.server.tsapps/webapp/test/apiBatchResultsPresenter.dedicatedSeam.test.tsapps/webapp/test/apiBatchResultsPresenter.splitNPlus1.test.tsapps/webapp/test/apiRetrieveRunPresenter.groupedLockedWorker.test.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.danglingConnectedRuns.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsinternal-packages/run-engine/src/engine/tests/legacyRunNewTokenResumeFlow.test.tsinternal-packages/run-store/src/PostgresRunStore.connectedRunsBounded.test.tsinternal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-store/src/PostgresRunStore.hydratorSelectPushdown.test.tsinternal-packages/run-store/src/PostgresRunStore.sharedHydratedTarget.test.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/runOpsStore.groupedReads.test.tsinternal-packages/run-store/src/runOpsStore.residencyMismatchFallback.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-store/src/scheduleSeam.test.tsinternal-packages/run-store/src/types.ts
…int kind stampMintKindFlip injected the default mint kind into every org feature-flag save, so an unrelated flag change wrote an explicit per-org runOpsMintKind override, pinning the org to that kind and making a later global flip silently skip it. Only stamp when the save actually sets runOpsMintKind.
The raw queries reading a waitpoint's connected runs relied on search_path, so they broke on deployments using a non-public database schema. Qualify the tables with the configured schema so they resolve correctly.
…ields An org's first per-org mint-flag override computed its cutover grace window against the wrong baseline, which could skip the grace window and briefly let two concurrent triggers sharing an idempotency key resolve to different databases. Seed the baseline from the effective global flag, strip the derived stamp fields from the request body, and apply the read-and-stamp atomically.
…d schema The dedicated-schema hydrator for a waitpoint's connectedRuns relation fetched an unbounded list of connections and full run rows. Bound it per parent with a window function so a waitpoint with many connections cannot pull a large result set for a display-only field.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/webapp/test/waitpointPresenter.schemaQualified.test.ts (1)
19-20: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPrefer a static import for
Prisma.This unconditional dynamic import violates the repository rule favoring static imports. Move
Prismato the module-level imports unless Vitest hoisting specifically requires this pattern.Proposed fix
+import { Prisma } from "`@trigger.dev/database`"; import { describe, expect, vi } from "vitest"; vi.mock("~/db.server", async () => { - const { Prisma } = await import("`@trigger.dev/database`");Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: cc7289ed-f395-421b-855c-132a8c044e56
📒 Files selected for processing (15)
apps/webapp/app/presenters/v3/WaitpointPresenter.server.tsapps/webapp/app/routes/admin.api.v1.orgs.$organizationId.feature-flags.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.tsapps/webapp/test/waitpointPresenter.connectedRunsBounded.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.danglingConnectedRuns.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/test/waitpointPresenter.splitConnectedRuns.test.tsinternal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsinternal-packages/run-store/src/PostgresRunStore.groupedRelations.test.tsinternal-packages/run-store/src/PostgresRunStore.ts
🚧 Files skipped from review as they are similar to previous changes (7)
- apps/webapp/test/waitpointPresenter.danglingConnectedRuns.test.ts
- apps/webapp/test/waitpointPresenter.splitConnectedRuns.test.ts
- internal-packages/run-store/src/PostgresRunStore.groupedRelations.test.ts
- apps/webapp/test/waitpointPresenter.connectedRunsBounded.test.ts
- apps/webapp/app/presenters/v3/WaitpointPresenter.server.ts
- apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.feature-flags.ts
- internal-packages/run-store/src/PostgresRunStore.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (26)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: typecheck / typecheck
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: code-quality / code-quality
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamicimport(); only use dynamic imports when resolving circular dependencies, enabling real code splitting, or conditionally loading a module at runtime.
Always import from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or the deprecatedclient.defineJob.
Files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
**/*.test.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Place test files next to their source files, e.g.
MyService.ts->MyService.test.ts.
Files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathAlways use
findFirstinstead offindUniquefor Prisma queries.
Files:
apps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable
Files:
apps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.ts
apps/webapp/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
In test files, never import
env.server.ts; pass configuration as options instead.
Files:
apps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.ts
apps/webapp/app/routes/**/*.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Use Remix flat-file route naming with dot-separated segments in
app/routes/(for example,api.v1.tasks.$taskId.trigger.tsmaps to/api/v1/tasks/:taskId/trigger).
Files:
apps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.ts
🧠 Learnings (18)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.tsapps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/test/waitpointPresenter.readthrough.test.tsapps/webapp/test/waitpointPresenter.controlPlane.test.tsapps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.tsapps/webapp/test/waitpointPresenter.schemaQualified.test.tsapps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.tsapps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts
🔇 Additional comments (8)
apps/webapp/app/v3/runOpsMigration/mintFlipGrace.ts (1)
17-26: LGTM!Also applies to: 35-45, 61-74, 87-118
apps/webapp/app/v3/runOpsMigration/mintFlipGrace.test.ts (1)
235-257: LGTM!Also applies to: 259-322
apps/webapp/app/routes/admin.api.v2.orgs.$organizationId.feature-flags.ts (1)
111-130: LGTM!Also applies to: 132-182
internal-packages/run-store/src/PostgresRunStore.connectedRunsIncludeBounded.test.ts (1)
1-117: LGTM!Also applies to: 125-127
apps/webapp/test/waitpointPresenter.controlPlane.test.ts (1)
35-35: LGTM!apps/webapp/test/waitpointPresenter.dedicatedConnectedRuns.readthrough.test.ts (1)
34-34: LGTM!apps/webapp/test/waitpointPresenter.schemaQualified.test.ts (1)
14-18: LGTM!Also applies to: 21-237
apps/webapp/test/waitpointPresenter.readthrough.test.ts (1)
42-42: LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two threads on the run-ops split path.
Read path: per-item run reads are batched into grouped queries, a waitpoint's connected-run reads are bounded, and the dedicated-schema relation hydrators fetch only the requested columns instead of whole rows. Retrieve also falls back to the other database when a routed read misses, so a run whose physical residency diverges from its id shape is still found rather than returning a spurious not-found. Fewer and lighter queries on the run read path, with no change to results.
Mint-kind flip safety: flipping which database new runs mint to is now a deterministic wall-clock cutover, for both per-org and global flips. For a grace window every process resolves the same database, so a flip cannot route two concurrent triggers that share an idempotency key to different databases (which would bypass the per-database unique constraint and create a duplicate run).
Supersedes the earlier #4205 and #4208.
Draft: validation in progress.