-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(webapp): redesign the side menu project and organization menus #4066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samejr
wants to merge
28
commits into
main
Choose a base branch
from
samejr/org-menu-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c6138e3
feat(webapp): split the side menu project and organization menus
samejr f2e8a0e
feat(webapp): dim project menu trigger and add environment tooltip
samejr 440023b
feat(webapp): connect the environment selector to the project menu
samejr d7c6af0
feat(webapp): size side menu popover items to match the nav items
samejr 3aa2886
feat(webapp): pin the project and environment selectors above the scr…
samejr e9fe1d0
feat(webapp): make the side menu env switcher a segmented control
samejr f2a3cbe
feat(webapp): refine side menu selectors and spacing
samejr 8e37da9
feat(webapp): polish the project selector, help menu, and collapsed s…
samejr 2fe465c
feat(webapp): align the project section padding with the nav items
samejr 8f99e6a
Merge remote-tracking branch 'origin/main' into samejr/org-menu-update
samejr f593730
feat(webapp): add a collapse toggle button to the side menu footer
samejr d5c39f5
feat(webapp): remove the middle collapse handle in favor of the foote…
samejr 24557d8
fix(webapp): keep the project section bottom padding constant when co…
samejr 0b0f66d
feat(webapp): add an account menu to the side menu header
samejr 26aa1be
feat(webapp): use a custom chain link icon for private connections
samejr 6d701ab
feat(webapp): use the custom avatar icon for the profile picture plac…
samejr 347fabe
feat(webapp): redesign the account profile page with a row-based layout
samejr 0645834
feat(webapp): match the environment selector popover item sizing to t…
samejr 72cd93d
feat(webapp): highlight impersonation mode in the side menu
samejr c7e7766
feat(webapp): move Settings to the top of the organization settings s…
samejr ea62538
feat(webapp): align org and account side menu padding with the main s…
samejr 08c2ab7
fix(webapp): match Help & Feedback popover Shortcuts and Contact us i…
samejr 1a574d7
fix(webapp): keep the keyboard shortcut hint on the Help & Feedback S…
samejr 71c540b
feat(webapp): make the side menu resizable by dragging its right edge
samejr 11efa95
feat(webapp): move Ask AI into the Help & Feedback menu
samejr 907288a
feat(webapp): refine the side menu resize handle and trim the Manage …
samejr aa15a48
feat(webapp): snap side menu button hovers, add Help & Feedback chevron
samejr aec6288
fix(webapp): only render the Help & Feedback chevron when expanded
samejr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| --- | ||
| area: webapp | ||
| type: improvement | ||
| --- | ||
|
|
||
| Refresh the side menu and account UI: | ||
|
|
||
| - Add a new "Project" section above the "Environment" section with a popover | ||
| that lists the org's projects (folder icon + checkmark for the selected one) | ||
| and a "New project" item at the bottom. | ||
| - The top-left menu now shows the organization (avatar + org name, no | ||
| project/diagonal divider) and its popover is a clean list of org-level items | ||
| (Settings, Usage, Billing with plan badge, Billing alerts, Team, Private | ||
| connections, Roles, SSO, Vercel integration, Slack integration, Switch | ||
| organization), with a separate account menu button (Profile, Personal Access | ||
| Tokens, Security, admin/impersonation, Logout) beside it. | ||
| - Match the Environment selector popover's item sizing (icons and labels, | ||
| including the branch submenu and its footer) to the Project popover so the two | ||
| side-menu menus are visually consistent. | ||
| - Redesign the account Profile page (/account) into the Security page's | ||
| row-and-divider layout: Profile picture, Full name, Email address, and a | ||
| "Receive onboarding emails" toggle on equal-height rows, with a primary Update | ||
| button. | ||
| - Signal impersonation mode with a yellow side-menu border and a matching | ||
| "Stop impersonating" accent. | ||
| - Move the Settings item to the top of the organization settings side menu. | ||
| - Align the organization settings and account side menus' horizontal padding | ||
| with the main side menu, and tighten the "Personal Access Tokens" label so it | ||
| no longer truncates. | ||
| - Restyle the "Shortcuts" and "Contact us…" entries in the Help & Feedback | ||
| popover to match the other menu items (icon size/alignment, dimmed text, text | ||
| size). | ||
| - Make the main side menu resizable: drag its right edge to set a custom width | ||
| (remembered per user), with the labels, headers, and padding transitioning in | ||
| real time and a snap to open or collapsed when released below the default | ||
| width. Clicking the edge toggles the menu and a tooltip explains both | ||
| gestures. | ||
|
|
||
| The org loader now exposes whether the RBAC and SSO plugins are installed so the | ||
| side menu can gate the Roles and SSO items the same way the settings side menu | ||
| does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| export function ChainLinkIcon({ className }: { className?: string }) { | ||
| return ( | ||
| <svg | ||
| className={className} | ||
| width="24" | ||
| height="24" | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| <path | ||
| d="M10 19.0004L9.82843 19.1719C8.26634 20.734 5.73368 20.734 4.17158 19.1719L3.82843 18.8288C2.26634 17.2667 2.26633 14.734 3.82843 13.1719L7.17158 9.8288C8.73368 8.2667 11.2663 8.2667 12.8284 9.8288L13.1716 10.1719C13.8252 10.8256 14.2053 11.6491 14.312 12.5004" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M9.68799 12.5004C9.79463 13.3516 10.1748 14.1752 10.8284 14.8288L11.1715 15.1719C12.7336 16.734 15.2663 16.734 16.8284 15.1719L20.1715 11.8288C21.7336 10.2667 21.7336 7.73404 20.1715 6.17194L19.8284 5.8288C18.2663 4.2667 15.7336 4.2667 14.1715 5.8288L14 6.00037" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| </svg> | ||
| ); | ||
| } |
22 changes: 22 additions & 0 deletions
22
apps/webapp/app/assets/icons/LeftSideMenuCollapsedIcon.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| export function LeftSideMenuCollapsedIcon({ className }: { className?: string }) { | ||
| return ( | ||
| <svg | ||
| className={className} | ||
| width="24" | ||
| height="24" | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| <rect x="4" y="4" width="16" height="16" rx="3" stroke="currentColor" strokeWidth="2" /> | ||
| <rect x="6" y="6" width="2" height="12" rx="1" fill="currentColor" /> | ||
| <path | ||
| d="M12 14.5L14.5 12L12 9.5" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| </svg> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import { motion } from "framer-motion"; | ||
| import { useState } from "react"; | ||
|
|
||
| export function LeftSideMenuIcon({ | ||
| className, | ||
| hovered: controlledHovered, | ||
| }: { | ||
| className?: string; | ||
| /** | ||
| * When provided, the shape animation is driven by this prop (e.g. from a | ||
| * parent button's hover). When omitted, the icon animates on its own hover. | ||
| */ | ||
| hovered?: boolean; | ||
| }) { | ||
| const [internalHovered, setInternalHovered] = useState(false); | ||
| const isControlled = controlledHovered !== undefined; | ||
| const hovered = isControlled ? controlledHovered : internalHovered; | ||
|
|
||
| return ( | ||
| <svg | ||
| className={className} | ||
| width="24" | ||
| height="24" | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| onMouseEnter={isControlled ? undefined : () => setInternalHovered(true)} | ||
| onMouseLeave={isControlled ? undefined : () => setInternalHovered(false)} | ||
| > | ||
| <rect x="4" y="4" width="16" height="16" rx="2" stroke="currentColor" strokeWidth="2" /> | ||
| {/* Animate a transform (scaleX) rather than the SVG `width` attribute: | ||
| framer snaps the first animation of an SVG geometry attribute after it | ||
| has been idle, whereas transforms animate reliably. Anchoring the origin | ||
| to the left edge collapses the panel from right to left. */} | ||
| <motion.rect | ||
| x="6" | ||
| y="6" | ||
| width="5" | ||
| height="12" | ||
| rx="1" | ||
| fill="currentColor" | ||
| initial={false} | ||
| style={{ originX: 0 }} | ||
| animate={{ scaleX: hovered ? 0.2 : 1 }} | ||
| transition={{ duration: 0.3, ease: "easeInOut" }} | ||
| /> | ||
| </svg> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Old AskAI export kept alongside new AskAIRoot — potential for duplicate Kapa providers
The original
AskAIcomponent (with its ownKapaProvideranduseAskAIState) is still exported fromAskAI.tsx:141. The newAskAIRoot(AskAI.tsx:86) also creates aKapaProvideranduseAskAIState. Both contain auseEffectthat reads and deletes the?aiHelp=URL param. If any future code renders both on the same page, there would be duplicate Kapa providers and a race on the URL param deletion. Currently safe becauseAskAIwas removed from all three side menus in this PR, but the dangling export is a footgun. Consider deprecating or removing the oldAskAIexport if it's no longer needed.(Refers to lines 141-167)
Was this helpful? React with 👍 or 👎 to provide feedback.