ci: harden release workflow against npm supply-chain attacks#21
Merged
Conversation
- Drop cache: npm so a fork-PR-poisoned cache can't be restored on the release path. - Install with --ignore-scripts to block postinstall hooks while id-token: write is held; npm run build still runs tsc explicitly. Inspired by the TanStack mini-Shai-Hulud postmortem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by the TanStack mini-Shai-Hulud postmortem.
cache: npmin the release job so a fork-PR-poisoned cache cannot be restored on the release path.npm ci --ignore-scriptsto block postinstall hooks whileid-token: writeis held.npm run buildalready runstscexplicitly afterwards, so dropping thepreparehook is safe.npx -y npm@latest publishleft as-is since npm trusted publishing currently requiresnpm >= 11.5.1.Test plan
npm testpasses locally (79/79)