Fix variable name: weapon -> fruit in list comprehension example (#105)#113
Open
xy769 wants to merge 1 commit intotrekhleb:masterfrom
Open
Fix variable name: weapon -> fruit in list comprehension example (#105)#113xy769 wants to merge 1 commit intotrekhleb:masterfrom
xy769 wants to merge 1 commit intotrekhleb:masterfrom
Conversation
…khleb#105) The context is a fruit list ('fresh_fruit'), so using 'weapon' as the iteration variable is confusing. Changed to 'fruit' for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue #105.
In the list comprehension example that cleans whitespace from fruit names, the iteration variable was incorrectly named weapon instead of fruit. Since the list is called fresh_fruit and contains fruit names, using weapon is confusing for learners.
Changes
Verification
The assertion still passes:
assert clean_fresh_fruit == [banana, loganberry, passion fruit]