Skip to content

[Feature/giscus] add giscus support#536

Open
sgamerw wants to merge 8 commits intotransitive-bullshit:mainfrom
sgamerw:feature/giscus
Open

[Feature/giscus] add giscus support#536
sgamerw wants to merge 8 commits intotransitive-bullshit:mainfrom
sgamerw:feature/giscus

Conversation

@sgamerw
Copy link
Copy Markdown

@sgamerw sgamerw commented Aug 28, 2023

Description

add giscus support, not add config to site.config.ts, maybe too simple and crude, but it works.

Notion Test Page ID

I test it locally, and comment success to giscus repo.
https://github.com/orgs/giscus/discussions/1160

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 28, 2023

@sgamerw is attempting to deploy a commit to the Saasify Team on Vercel.

A member of the Team first needs to authorize it.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Aug 28, 2023

Comment thread components/PageFooter.tsx Outdated
Comment on lines +15 to +18
repo="giscus/giscus"
repoId="MDEwOlJlcG9zaXRvcnkzNTE5NTgwNTM="
category="General"
categoryId="MDE4OkRpc2N1c3Npb25DYXRlZ29yeTMyNzk2NTc1"
Copy link
Copy Markdown

@laymonage laymonage Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, but please don't use these as the default, otherwise people who haven't configured the values with their own repo will spam the giscus repo with their discussions.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, maybe just keep these configuration empty, then tell users how to set these in docs/wiki/readme?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't add configs to site.config.ts, there are too many values, so what's your suggestion?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laymonage already remove the giscus repo information, made these keys into config for giscus.

@transitive-bullshit
Copy link
Copy Markdown
Owner

This looks like a really great starting point for Giscus support, which I'm a fan of. I don't think it should be enabled by default or, as you mentioned, it should be optional and configured via the config file.

@sgamerw
Copy link
Copy Markdown
Author

sgamerw commented Dec 22, 2023

Thanks for reply, I'll add config for Giscus ASAP.

@YesYouKenSpace
Copy link
Copy Markdown

YesYouKenSpace commented Jul 11, 2024

Is this not ready? @sgamerw @transitive-bullshit

@yanyanlongxia
Copy link
Copy Markdown

Glad to see this feature still works!
I've successfully deployed giscus in my site. Thank you guys!

@sgamerw
Copy link
Copy Markdown
Author

sgamerw commented Sep 29, 2024

This looks like a really great starting point for Giscus support, which I'm a fan of. I don't think it should be enabled by default or, as you mentioned, it should be optional and configured via the config file.

@transitive-bullshit hi, already add configs and Giscus was disabled by default.

@sgamerw
Copy link
Copy Markdown
Author

sgamerw commented Sep 29, 2024

I'm really looking forward to this feature. I hope this can be implemented soon!

already done,wait for reviewer to approve.

@sgamerw sgamerw requested a review from laymonage October 9, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants