[Feature/giscus] add giscus support#536
[Feature/giscus] add giscus support#536sgamerw wants to merge 8 commits intotransitive-bullshit:mainfrom
Conversation
(cherry picked from commit f889410)
|
@sgamerw is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/notion-client@6.15.6, npm/notion-types@6.15.6, npm/notion-utils@6.15.6, npm/react-notion-x@6.15.6 |
| repo="giscus/giscus" | ||
| repoId="MDEwOlJlcG9zaXRvcnkzNTE5NTgwNTM=" | ||
| category="General" | ||
| categoryId="MDE4OkRpc2N1c3Npb25DYXRlZ29yeTMyNzk2NTc1" |
There was a problem hiding this comment.
Thank you for this PR, but please don't use these as the default, otherwise people who haven't configured the values with their own repo will spam the giscus repo with their discussions.
There was a problem hiding this comment.
so, maybe just keep these configuration empty, then tell users how to set these in docs/wiki/readme?
There was a problem hiding this comment.
I haven't add configs to site.config.ts, there are too many values, so what's your suggestion?
There was a problem hiding this comment.
@laymonage already remove the giscus repo information, made these keys into config for giscus.
(cherry picked from commit 559ba73)
|
This looks like a really great starting point for Giscus support, which I'm a fan of. I don't think it should be enabled by default or, as you mentioned, it should be optional and configured via the config file. |
|
Thanks for reply, I'll add config for Giscus ASAP. |
|
Is this not ready? @sgamerw @transitive-bullshit |
|
Glad to see this feature still works! |
…notion-starter-kit into transitive-bullshit-main # Conflicts: # package.json
@transitive-bullshit hi, already add configs and Giscus was disabled by default. |
already done,wait for reviewer to approve. |
Description
add giscus support, not add config to site.config.ts, maybe too simple and crude, but it works.
Notion Test Page ID
I test it locally, and comment success to giscus repo.
https://github.com/orgs/giscus/discussions/1160