perf: Cache bounds() results in AbstractEdit#111
Open
Conversation
Add caching for bounds() method in AbstractEdit to reduce redundant Range object creation. Profiling showed bounds() was called 230k+ times for a 200-element list diff, often returning the same values. Changes: - Add _cached_bounds attribute initialized to None - Return cached value if available - Add invalidate_bounds_cache() method for cache invalidation Note: Subclasses that override bounds() (like PossibleEdits, EditCollection) manage their own caching. This primarily benefits ConstantCostEdit subclasses and calls to super().bounds(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bounds()method inAbstractEditChanges
Profiling showed
bounds()was called 230k+ times for a 200-element list diff, often returning the same values. This adds a simple cache:_cached_boundsattribute initialized to Nonebounds()invalidate_bounds_cache()method for cache invalidationNote: Subclasses that override
bounds()(likePossibleEdits,EditCollection) manage their own caching. This primarily benefitsConstantCostEditsubclasses and calls tosuper().bounds().Test plan
🤖 Generated with Claude Code