[FIX] Remove deprecated verbose flag from ReduceLROnPlateau in tests#29
Merged
arokem merged 3 commits intotractometry:mainfrom Oct 24, 2025
Merged
[FIX] Remove deprecated verbose flag from ReduceLROnPlateau in tests#29arokem merged 3 commits intotractometry:mainfrom
arokem merged 3 commits intotractometry:mainfrom
Conversation
Contributor
chiuhoward
commented
Oct 24, 2025
chiuhoward
commented
- Removed verbose parameter from ReduceLROnPlateau in test_pt_models.py
- Removed verbose parameter from ReduceLROnPlateau in test_tf_models.py
- Fixed Mahalanobis typos along the way
- All tests passing after changes
- Removed verbose parameter from ReduceLROnPlateau in test_pt_models.py - Removed verbose parameter from ReduceLROnPlateau in test_tf_models.py - All tests passing after changes
arokem
requested changes
Oct 24, 2025
Member
arokem
left a comment
arokem
left a comment
There was a problem hiding this comment.
Looks good! I think that we don't need the comments in the code, so I have a couple of suggestions to remove those. I will commit those suggestions and then merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.