Add coil3 extension - #479
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new kermit-coil3 extension module so Coil 3’s logging can be routed into Kermit, plus the necessary Gradle wiring to include/publish the new extension.
Changes:
- Register the new
:kermit-coil3Gradle module and add Coil 3 to the version catalog. - Introduce
KermitCoil3Loggerimplementing Coil 3’sLogger, plus level/Severity conversion extensions. - Add module build configuration, public API dumps, and end-user README documentation.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Includes the new :kermit-coil3 project and maps it to extensions/kermit-coil3. |
| gradle/libs.versions.toml | Adds Coil 3 version and coil3-core library alias for dependency management. |
| extensions/kermit-coil3/src/commonMain/kotlin/co/touchlab/kermit/coil3/KermitCoil3Logger.kt | Adds a Coil 3 Logger implementation backed by a Kermit Logger. |
| extensions/kermit-coil3/src/commonMain/kotlin/co/touchlab/kermit/coil3/Extensions.kt | Adds public conversion extensions between Coil 3 Logger.Level and Kermit Severity. |
| extensions/kermit-coil3/README.md | Documents how to wire KermitCoil3Logger into a Coil 3 ImageLoader. |
| extensions/kermit-coil3/build.gradle.kts | Adds the new KMP extension module build/publish configuration and targets. |
| extensions/kermit-coil3/api/jvm/kermit-coil3.api | Adds JVM API dump for binary compatibility tracking. |
| extensions/kermit-coil3/api/android/kermit-coil3.api | Adds Android API dump for binary compatibility tracking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
faogustavo
left a comment
There was a problem hiding this comment.
Thanks for the PR. This looks good. Just adding some minor requests. Let us know if you can work on those.
faogustavo
left a comment
There was a problem hiding this comment.
LGTM. @KevinSchildhorn can we have a second pair of eyes here? :D
|
I've been thinking, do we need to add a separator parameter in the constructor for joining the Kermit tag and Coil tag? Right now the |
That sounds alright to me, or maybe a default coil tag. I agree it could be an awkward separator. |
Done |
|
By the way, it looks like |
Uh oh!
There was an error while loading. Please reload this page.