Implement json_contains filter for SQLite backend#2121
Open
Br1an67 wants to merge 2 commits intotortoise:developfrom
Open
Implement json_contains filter for SQLite backend#2121Br1an67 wants to merge 2 commits intotortoise:developfrom
Br1an67 wants to merge 2 commits intotortoise:developfrom
Conversation
Update main branch
Register a custom json_contains function on SQLite connections that implements JSON containment semantics matching PostgreSQL's @> operator. Arrays check element-wise inclusion, objects check key-value subset, and scalars check equality. Closes tortoise#1961
abondar
reviewed
Mar 3, 2026
| def _json_contains_impl(target_str: str | None, candidate_str: str | None) -> bool: | ||
| """Check if target JSON value contains the candidate JSON value. | ||
|
|
||
| Semantics match PostgreSQL's @> operator: |
Member
There was a problem hiding this comment.
I don't think we should be referencing postgresql implementation in sqlite contrib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement the
json_containsfilter for the SQLite backend by registering a customjson_containsPython function on SQLite connections. The function implements JSON containment semantics matching PostgreSQL's@>operator:Motivation and Context
Closes #1961.
Using
data__containson aJSONFieldwith SQLite throwsNotImplementedError: must be overridden in each executor. This makes it impossible to write database-agnostic code that filters JSON fields. PostgreSQL and MySQL both support this filter; this PR adds SQLite support.How Has This Been Tested?
test_list_containsintests/fields/test_json.pyto also run on SQLite (was previously restricted to MySQL and PostgreSQL)Checklist: