Projects api v6 by jmgasper · Pull Request #1735 · topcoder-platform/work-manager

jmgasper · 2026-03-03T04:53:17Z

No description provided.

…scorecard phase change and selection.

…ot display

github-actions · 2026-03-03T04:53:33Z

config/constants/development.js

  CHALLENGE_TIMELINES_URL: `${DEV_API_HOSTNAME}/v6/challenge-timelines`,
  COPILOTS_URL: 'https://copilots.topcoder-dev.com',
-  PROJECT_API_URL: `${DEV_API_HOSTNAME}/v5/projects`,
+  PROJECT_API_URL: `${DEV_API_HOSTNAME}/v6/projects`,


[❗❗ correctness]
Ensure that all dependent services and clients are updated to use the new v6 endpoint for projects. This change could break functionality if any part of the system still relies on the v5 endpoint.

github-actions · 2026-03-03T04:53:36Z

config/constants/local.js

-  // Projects API: keep dev unless you run projects locally
-  PROJECT_API_URL: `${DEV_API_HOSTNAME}/v5/projects`,
+  // Projects API v6: keep dev default (switch to LOCAL_PROJECTS_API when needed)
+  PROJECT_API_URL: `${DEV_API_HOSTNAME}/v6/projects`,


[❗❗ correctness]
The change from v5 to v6 in the PROJECT_API_URL may require verification that all dependent services and clients are compatible with the new API version. Ensure that any breaking changes in the API are addressed.

github-actions · 2026-03-03T04:53:38Z

config/constants/production.js

  CHALLENGE_TIMELINES_URL: `${PROD_API_HOSTNAME}/v6/challenge-timelines`,
  COPILOTS_URL: `https://copilots.${DOMAIN}`,
-  PROJECT_API_URL: `${PROD_API_HOSTNAME}/v5/projects`,
+  PROJECT_API_URL: `${PROD_API_HOSTNAME}/v6/projects`,


[❗❗ correctness]
Ensure that all dependencies and services consuming the PROJECT_API_URL are compatible with the new API version v6. This change might introduce breaking changes if the API endpoints have different contracts between v5 and v6.

github-actions · 2026-03-03T04:53:43Z

src/components/ChallengeEditor/ChallengeReviewer-Field/index.js

  return null
 }

+const normalizePhaseToken = (value) => (value || '')


[⚠️ correctness]
The normalizePhaseToken function removes the word 'phase' from the end of the string. Ensure this behavior is intended, as it might lead to unexpected results if 'phase' is a meaningful part of the phase name.

github-actions · 2026-03-03T04:53:43Z

src/components/ChallengeEditor/ChallengeReviewer-Field/index.js

+)
+
+const getScorecardsForPhase = (scorecards = [], phases = [], phaseId) => {
+  const normalizedPhaseId = normalizeIdValue(phaseId)


[💡 maintainability]
In getScorecardsForPhase, the function returns an empty array if normalizedPhaseId is falsy. Consider logging or handling this scenario if it indicates a potential issue with the input data.

github-actions · 2026-03-03T04:53:43Z

src/components/ChallengeEditor/ChallengeReviewer-Field/index.js

        incrementalCoefficient: defaultReviewer.incrementalCoefficient
      })
+
+      if (updatedReviewers[index] && (updatedReviewers[index].isMemberReview !== false)) {


[💡 readability]
The logic for updating fieldUpdate.scorecardId when hasCurrentScorecard is false could be simplified for clarity. Consider refactoring to make the fallback logic more explicit.

github-actions · 2026-03-03T04:53:43Z

src/components/ChallengeEditor/ChallengeReviewer-Field/index.js

    const { scorecards = [], workflows = [] } = metadata
    const validationErrors = challenge.submitTriggered ? this.validateReviewer(reviewer) : {}
-    const selectedPhase = challenge.phases.find(p => p.phaseId === reviewer.phaseId)
+    const filteredScorecards = getScorecardsForPhase(


[⚠️ correctness]
The getScorecardsForPhase function is used to filter scorecards based on phase. Ensure that the filtering logic aligns with the intended business rules, especially if phase names or IDs can change.

github-actions · 2026-03-03T04:53:47Z

src/components/ChallengeEditor/ChallengeView/index.js

  if (isLoading || _.isEmpty(metadata.challengePhases) || challenge.id !== challengeId) return <Loader />
  const showTimeline = false // disables the timeline for time being https://github.com/topcoder-platform/challenge-engine-ui/issues/706
  const isTask = _.get(challenge, 'task.isTask', false)
+  const isFunChallenge = challenge.funChallenge === true


[💡 correctness]
The isFunChallenge variable is set using a strict equality check (=== true). Consider using a more flexible check like !!challenge.funChallenge to handle cases where funChallenge might be truthy but not strictly true.

github-actions · 2026-03-03T04:53:47Z

src/components/ChallengeEditor/ChallengeView/index.js

              <>
                {dashboardToggle}
                <NDAField beta challenge={challenge} readOnly />
+                <WiproAllowedField challenge={challenge} onUpdateOthers={() => {}} readOnly />


[💡 maintainability]
The onUpdateOthers prop for WiproAllowedField is passed an empty function. If this is intentional, consider adding a comment explaining why it's necessary to pass this prop with an empty function. If not needed, it might be cleaner to omit it.

github-actions · 2026-03-03T04:53:51Z

src/components/ChallengeEditor/FunChallengeField/FunChallengeField.module.scss

+    position: relative;
+    display: inline-block;
+
+    input[type='checkbox'] {


[⚠️ accessibility]
Hiding the checkbox input with display: none; can cause accessibility issues, as screen readers may not be able to interact with it. Consider using opacity: 0; and position: absolute; to hide it visually while keeping it accessible.

github-actions · 2026-03-03T04:53:51Z

src/components/ChallengeEditor/FunChallengeField/FunChallengeField.module.scss

+        opacity: 0.3;
+      }
+
+      div {


[⚠️ design]
The div inside the label might cause layout issues if the label is intended to be a clickable area for the checkbox. Ensure that the div does not interfere with the expected behavior of the label.

github-actions · 2026-03-03T04:53:54Z

src/components/ChallengeEditor/FunChallengeField/index.js

+          id='funChallenge'
+          checked={isFunChallenge}
+          readOnly={readOnly}
+          onChange={() => onUpdateOthers({ field: 'funChallenge', value: !isFunChallenge })}


[⚠️ performance]
The onChange handler directly calls onUpdateOthers with a new object every time the checkbox is toggled. Consider memoizing the handler using useCallback to prevent unnecessary re-renders and improve performance.

github-actions · 2026-03-03T04:53:54Z

src/components/ChallengeEditor/FunChallengeField/index.js

+        />
+        <label htmlFor='funChallenge'>
+          <div>Fun Challenge</div>
+          <input type='hidden' />


[💡 maintainability]
The <input type='hidden' /> inside the <label> seems unnecessary and could be removed unless it serves a specific purpose not evident from the current context.

github-actions · 2026-03-03T04:53:58Z

src/components/ChallengeEditor/WiproAllowedField/WiproAllowedField.module.scss

+    position: relative;
+    display: inline-block;
+
+    input[type='checkbox'] {


[❗❗ accessibility]
Hiding the checkbox input with display: none; can cause accessibility issues, as screen readers may not be able to interact with it. Consider using visually-hidden techniques instead to ensure accessibility.

github-actions · 2026-03-03T04:53:58Z

src/components/ChallengeEditor/WiproAllowedField/WiproAllowedField.module.scss

+      line-height: 17px;
+      font-weight: 300;
+      cursor: pointer;
+      position: absolute;


[⚠️ correctness]
Using position: absolute; for the label without specifying a containing block can lead to unexpected positioning issues. Ensure that the parent element has position: relative; to avoid layout problems.

github-actions · 2026-03-03T04:53:58Z

src/components/ChallengeEditor/WiproAllowedField/WiproAllowedField.module.scss

+      border: none;
+      box-shadow: none;
+      background: $tc-gray-30;
+      transition: all 0.15s ease-in-out;


[⚠️ performance]
The use of transition: all 0.15s ease-in-out; can lead to performance issues as it transitions all properties. Consider specifying only the properties that need to be transitioned to improve performance.

github-actions · 2026-03-03T04:53:58Z

src/components/ChallengeEditor/WiproAllowedField/WiproAllowedField.module.scss

+    }
+
+    input[type='checkbox']:checked + label::after {
+      border-color: $white;


[❗❗ correctness]
The border-color property is being set to $white, but the ::after pseudo-element does not have a border initially. Ensure that a border is defined for the ::after element when checked.

github-actions · 2026-03-03T04:54:01Z

src/components/ChallengeEditor/WiproAllowedField/index.js

+          id='wiproAllowed'
+          checked={isWiproAllowed}
+          readOnly={readOnly}
+          onChange={() => onUpdateOthers({ field: 'wiproAllowed', value: !isWiproAllowed })}


[⚠️ correctness]
Consider adding a check to ensure onUpdateOthers is a function before calling it to prevent potential runtime errors if it's undefined or not a function.

github-actions · 2026-03-03T04:54:01Z

src/components/ChallengeEditor/WiproAllowedField/index.js

+        />
+        <label htmlFor='wiproAllowed'>
+          <div>Wipro Allowed</div>
+          <input type='hidden' />


[💡 maintainability]
The hidden input inside the label seems unnecessary unless it serves a specific purpose not evident from the current code. Consider removing it to simplify the component.

github-actions · 2026-03-03T04:54:02Z

src/components/ChallengeEditor/WiproAllowedField/index.js

+}
+
+WiproAllowedField.propTypes = {
+  challenge: PropTypes.shape().isRequired,


[⚠️ maintainability]
The PropTypes.shape() for challenge is too generic. Consider defining the expected shape of the challenge object to improve type safety and maintainability.

github-actions · 2026-03-03T04:54:08Z

src/components/ChallengeEditor/index.js

      if (!isSub) {
        newChallenge[field] = option
+        if (field === 'typeId' && option !== MARATHON_TYPE_ID) {
+          newChallenge.funChallenge = false


[⚠️ correctness]
The condition option !== MARATHON_TYPE_ID could potentially lead to unexpected behavior if option is null or undefined. Consider explicitly checking for these cases to ensure funChallenge is only reset when option is a valid non-Marathon type.

github-actions · 2026-03-03T04:54:08Z

src/components/ChallengeEditor/index.js

+    }
+
+    const copilotFee = _.find(challenge.prizeSets, p => p.type === PRIZE_SETS_TYPE.COPILOT_PAYMENT, [])
+    if (copilotFee && parseInt(copilotFee.prizes[0].value) > 0 && !challenge.copilot) {


[❗❗ correctness]
Ensure that copilotFee.prizes[0] exists before accessing value to avoid potential runtime errors. Consider adding a check for copilotFee.prizes and its length.

github-actions · 2026-03-03T04:54:08Z

src/components/ChallengeEditor/index.js

    challenge.timelineTemplateId = _.get(this.getCurrentTemplate(), 'id')
    challenge.projectId = this.props.projectId
-    challenge.prizeSets = challenge.prizeSets.map(p => {
+    challenge.prizeSets = (challenge.prizeSets || []).map(p => {


[❗❗ correctness]
The use of map on challenge.prizeSets assumes it is always an array. Consider adding a check to ensure prizeSets is defined and is an array to prevent potential runtime errors.

github-actions · 2026-03-03T04:54:08Z

src/components/ChallengeEditor/index.js

      return { ...p, prizes }
    })
+    if (challenge.funChallenge === true) {
+      delete challenge.prizeSets


[⚠️ design]
Deleting prizeSets when funChallenge is true might lead to unexpected behavior if other parts of the code rely on prizeSets being present. Ensure that this deletion is safe and won't cause issues elsewhere.

github-actions · 2026-03-03T04:54:11Z

src/containers/ChallengeEditor/index.js

+        loadChallengeDetails,
+        loadResources,
+        loadSubmissions,
+        submissionsPerPage


[⚠️ correctness]
The submissionsPerPage parameter is added to the fetchChallengeDetails method call. Ensure that this parameter is correctly handled within the fetchChallengeDetails method to avoid potential issues with pagination or data fetching.

github-actions · 2026-03-03T04:54:14Z

src/containers/Challenges/index.js

      fetchNextProjects
    } = this.props
    const { challengeTypes = [] } = metadata
+    const isActiveProjectLoaded =


[💡 performance]
The use of template literals for comparing reduxProjectInfo.id and activeProjectId is unnecessary and could be replaced with a direct comparison. This would improve performance slightly by avoiding the overhead of string conversion.

github-actions · 2026-03-03T04:54:17Z

src/services/challenges.js

 */
-export async function fetchSubmissions (challengeId, pageObj) {
-  const { page, perPage } = pageObj
+export async function fetchSubmissions (challengeId, pageObj = {}) {


[⚠️ correctness]
The pageObj parameter now has a default value of an empty object. Ensure that all usages of fetchSubmissions handle this change appropriately, as previously passing undefined would have resulted in a destructuring error.

github-actions · 2026-03-03T04:54:17Z

src/services/challenges.js

+export async function fetchSubmissions (challengeId, pageObj = {}) {
+  const page = _.get(pageObj, 'page', 1)
+  const perPage = _.get(pageObj, 'perPage', 10)
  const response = await axiosInstance.get(`${SUBMISSIONS_API_URL}?challengeId=${challengeId}&perPage=${perPage}&page=${page}`)


[⚠️ security]
Consider using encodeURIComponent for challengeId, perPage, and page when constructing the URL to prevent potential issues with special characters.

jmgasper added 2 commits February 25, 2026 13:41

Fun challenge, v6 projects api, wipro allowed flag, fix for reviewer …

ca9a89f

…scorecard phase change and selection.

Fix for project ID parsing issue that caused the projects header to n…

6f51c86

…ot display

jmgasper merged commit 82358f6 into develop Mar 3, 2026
4 of 5 checks passed

github-actions bot reviewed Mar 3, 2026

View reviewed changes

Conversation

jmgasper commented Mar 3, 2026

Uh oh!

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 3, 2026