Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| type='text' | ||
| error={formErrors.serviceProviderName} | ||
| dirty | ||
| forceUpdateValue |
There was a problem hiding this comment.
[correctness]
The forceUpdateValue prop is being added to the InputText component. Ensure that this prop is supported by the component and behaves as expected. If this is a custom prop, verify its necessity and implementation to avoid unintended side effects.
| name='softwareName' | ||
| label='Software Name *' | ||
| value={selectedSoftwareName} | ||
| forceUpdateValue |
There was a problem hiding this comment.
[❗❗ correctness]
The forceUpdateValue prop is not a standard prop for InputText. Ensure that this prop is supported by the component or remove it if unnecessary. Using unsupported props can lead to unexpected behavior.
| type='text' | ||
| error={formErrors.subscriptionName} | ||
| dirty | ||
| forceUpdateValue |
There was a problem hiding this comment.
[correctness]
The forceUpdateValue prop is added to the InputText component. Ensure that this prop is necessary and correctly implemented in the InputText component. If it forces a re-render or bypasses controlled component behavior, it could lead to unexpected side effects.
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [isLoading]) | ||
| }, [isLoading, props.open]) |
There was a problem hiding this comment.
[correctness]
Adding props.open to the dependency array of useCallback is correct to ensure the handleClose function updates when props.open changes. However, ensure that props.open is indeed a necessary dependency and that its inclusion does not cause unnecessary re-renders or logic issues.
2 participants
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-4004
https://topcoder.atlassian.net/browse/PM-4005
What's in this PR?