Upgrade to Bootstrap v5 and add dark mode support#343
Open
Upgrade to Bootstrap v5 and add dark mode support#343
Conversation
Collaborator
|
@Amdrel very nice! I see CI/Biome raised two warnings in video2commons.js, is it possible to resolve them? |
Collaborator
Author
|
Done. I also modified the workflow to clean up broken symlinks before the lint check. Those are needed by the application but biome seems to dislike them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Components: frontend, socket.io
Description
Resolves #331
This patch migrates the frontend to Bootstrap v5 and upgrades all other dependencies to the maximum versions possible taking compatibility into account. I've tested this patch a bit (including RTL) in both light and dark mode.
The application looks a bit more "modern" since Bootstrap 5 has different base styles than 3, however everything is still positioned in the same places as before.
Library Version Changes
1.13.1(replacing Glyphicons bundled with Bootstrap 3)3.3.6to5.3.82.2.0to3.7.10.1.1to0.2.32.3.13to^2.4.8>3.0.0to^5.0.1>3.1.1to^6.1.0>1.4.0to^2.1.0>2.1.2to^3.0.2^4.21.1to^5.2.1^4.6.12to^5.11.0^4.8.0to^4.8.30.14.14to0.15.7Code Changes
*(why?)Screenshots
Task list with dark mode applied
Add task dialog with dark mode applied
Target page with dark mode applied (labels have more bottom margin in final version)
Screenshot demonstrating that light mode still works
RTL support still working in Bootstrap 5 with Hebrew
Playlist dialog with updated styles