add script-tag-hook option for e.g. cookie consent#55
Open
tuomassalo wants to merge 1 commit intotonickkozlov:masterfrom
Open
add script-tag-hook option for e.g. cookie consent#55tuomassalo wants to merge 1 commit intotonickkozlov:masterfrom
tuomassalo wants to merge 1 commit intotonickkozlov:masterfrom
Conversation
Author
|
Oh, I noticed the test suite seems to be broken, so I didn't attempt to write tests for this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I'm proposing this PR as a way to suspend loading the Twitter platform
scripttag while we wait for the user to click on a cookie consent banner. This can be used with e.g. Cookiebot manual mode.