TZStackViewAlignment compatibility and better iOS 7 support#63
Open
andi357 wants to merge 9 commits intotomvanzummeren:masterfrom
Open
TZStackViewAlignment compatibility and better iOS 7 support#63andi357 wants to merge 9 commits intotomvanzummeren:masterfrom
andi357 wants to merge 9 commits intotomvanzummeren:masterfrom
Conversation
…settings, & update the deployment target to the lowest supported by the code.
… -- The enum values were in the wrong order, some were concrete values rather than aliases.
…ct adding of NSLayoutConstraints to NSLayoutConstraint.activateConstraints.
|
\o/ |
|
I support this PR! -- Have not run it yet. Minor documentation suggestion: the README.md was originally written differently, I suggest making this change to restore the clarity that this library is explicitly good for iOS 8: -- ✅ Compatible with **iOS 7.x** or later
+- ✅ Compatible with **iOS 7.x** and **iOS 8.x** or laterUsers might not choose a library targeting iOS 7 directly, if they're only trying to support 8 & 9. (It might not be clear if it's relying on deprecated functionality to continue working. -- Because of swift, it isn't!) |
|
iOS 7 support is already done by me in PR #59 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fork of PR #60 opened bei @fbartho. It adds compatibility between
TZStackViewAlignmentandUIStackViewAlignmentso you can easily convert those values in environments where you want to use TZStackView only if UIStackView is not available (< iOS 9.0).In contrast to #60 this PR fixes the iOS 7 support instead of removing it. Although some features are not available on iOS 7 (like
layoutMarginsRelativeArrangementorFirstBaselinealignment) there is no need to completely remove its support.