Dockerfile: Use unversioned golang:alpine image#37
Open
cfergeau wants to merge 1 commit intotommy-muehle:masterfrom
Open
Dockerfile: Use unversioned golang:alpine image#37cfergeau wants to merge 1 commit intotommy-muehle:masterfrom
cfergeau wants to merge 1 commit intotommy-muehle:masterfrom
Conversation
The Dockerfile hardcodes the use of golang:1.16-alpine. Both golang 1.16 and the alpine version used in this image are unmaintained at this point, with most likely some known unfixed security issues. This PR switches to an unversioned golang/alpine image, which should ensure we always use an up-to-date image. We can switch back to a versioned image if this causes issues and it turns out we need more predictability on the golang version used. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfile hardcodes the use of golang:1.16-alpine.
Both golang 1.16 and the alpine version used in this image are
unmaintained at this point, with most likely some known unfixed security
issues.
This PR switches to an unversioned golang/alpine image, which should
ensure we always use an up-to-date image.
We can switch back to a versioned image if this causes issues and it
turns out we need more predictability on the golang version used.