[WIP] Allowing link to be the absolute last step in the process#186
[WIP] Allowing link to be the absolute last step in the process#186mansona wants to merge 2 commits intotomdale:masterfrom stonecircle:feature/link-as-last-step
Conversation
| .then(() => this); | ||
| }; | ||
|
|
||
| AddonTestApp.prototype.link = function(appName) { |
There was a problem hiding this comment.
I would prefer to call it linkAddon or something like that, to disambiguate it a bit more
|
|
||
| function link(appName) { | ||
| return Promise.resolve() | ||
| .then(() => linkDependencies(appName)) |
There was a problem hiding this comment.
Shouldn't this rather call symlinkAddon() here?
|
@mansona I am not sure, are the changes in Tests are broken at least... |
|
@simonihmig you're right in saying that this is mostly for To be honest I'm surprised that you haven't come back to say my approach was a million miles off 🤔 I guess if I could get this working "downstream" with these changes I might be able to clean this up and expose |
2 participants
This is a work in progress PR that is supposed to spark a discussion around #176. it is also related to kaliber5/ember-fastboot-addon-tests#21
The idea is that we need to have the linking be the last step in the process after all times that
npm installis called. Asember-fastboot-addon-testsdoes some npm magic of its own it would need to run the linking functionality again at a time that is suitable for that addon. I have a demo of what I was trying to achieve kaliber5/ember-fastboot-addon-tests#22