Skip to content

Answer: 50 #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phhien203 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Answer: 50 #1453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions apps/signal/50-bug-in-effect/src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,20 @@ export class AppComponent {
gpu = model(false);

constructor() {
/*
Explain for your junior team mate why this bug occurs ...
/*
if we use `if (this.drive() || this.ram() || this.gpu())`,
when the drive is selected, this `this.drive()` will be evaluated to true,
and the short circuit will happen. So the rest this.ram() || this.gpu() in the `if` statement
is not evaluated. And Angular will understand that this effect only depends on the `drive` signal.
That's why when we select the second checkbox again, there's nothing happens.
The rule of thumbs is always express the signal dependency explicitly.
*/
effect(() => {
if (this.drive() || this.ram() || this.gpu()) {
const drive = this.drive();
const ram = this.ram();
const gpu = this.gpu();

if (drive || ram || gpu) {
alert('Price increased!');
}
});
Expand Down
Loading