Add --generate-completion flag for single-command apps and fix zsh completion#97
Merged
Add --generate-completion flag for single-command apps and fix zsh completion#97
Conversation
…mpletion. For commands with a run callback (and thus no subcommands), a "completion" subcommand cannot be auto-added. Fall back to a "--generate-completion <shell>" option on the root command instead, gated on the existing --add-completion flag. Fix zsh extension-filtered completion: replace parenthesized glob patterns like "(*.toml|*.yaml)" with one "_files -g" call per extension, since grouped patterns break _path_files directory-prefix navigation. Register completion bindings for the basename, the program-path as given, and a "./" prefixed variant for relative paths, so that completion works regardless of how the binary is invoked. Add examples/comp.toit demonstrating OptionPath with --extensions.
Member
Author
|
TBR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For commands with a run callback (and thus no subcommands), a "completion" subcommand cannot be auto-added. Fall back to a "--generate-completion " option on the root command instead, gated on the existing --add-completion flag.
Fix zsh extension-filtered completion: replace parenthesized glob patterns like "(.toml|.yaml)" with one "_files -g" call per extension, since grouped patterns break _path_files directory-prefix navigation.
Register completion bindings for the basename, the program-path as given, and a "./" prefixed variant for relative paths, so that completion works regardless of how the binary is invoked.
Add examples/comp.toit demonstrating OptionPath with --extensions.