Modernize web-app-serve: published validate-env package + helm wrapper chart - #29
Merged
Conversation
thenav56
force-pushed
the
feat/web-app-serve-helm
branch
2 times, most recently
from
July 16, 2026 13:42
60599ce to
52a5a93
Compare
Replace the retired @julr git-fork dependency (git+https://github.com/toggle-corp/vite-plugin-validate-env#v2.2.0-tc.1) with the published npm package @togglecorp/vite-plugin-validate-env ^2.2.1, which ships overrideDefineForWebAppServe and installs cleanly (no .npmrc pnpm auto-switch workaround needed). Update all imports @julr/... -> @togglecorp/... (env.ts, vite.config.ts, src/declarations/env.d.ts) and refresh the lockfile. Align web-app-serve/docker-compose.yml with current conventions: inline dynamic-var defaults via ${VAR:-default} and an optional local .env, overridable COMPOSE_PROJECT_NAME. Tidy stale nginx-serve wording.
Bump the publish workflow to the helm-capable action release (toggle-corp/web-app-serve-action@v0.2.0), set helm_publish: true, and add contents: read + pull-requests: read (the helm provenance writer resolves the PR from the commit). Rename publish-web-app-serve.yml -> helm-publish.yaml now that it publishes the chart too; keep submodules: true (backend schema). Add the thin wrapper chart under web-app-serve/helm/: Chart.yaml (name timur-helm, base web-app-serve-helm 0.1.1 aliased app, SET-BY-CICD version) and values.yaml (app.fullnameOverride timur, SET-BY-CICD image placeholders, pre-seeded app.ingress.annotations). CI resolves the image name/tag and stamps provenance annotations on publish.
thenav56
force-pushed
the
feat/web-app-serve-helm
branch
from
July 16, 2026 15:08
52a5a93 to
b56daf9
Compare
tnagorra
approved these changes
Jul 17, 2026
tnagorra
pushed a commit
that referenced
this pull request
Jul 27, 2026
Modernize web-app-serve: published validate-env package + helm wrapper chart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
chore:— migrate to published@togglecorp/vite-plugin-validate-env@julr/vite-plugin-validate-env(git+…#v2.2.0-tc.1) with the published npm package@togglecorp/vite-plugin-validate-env@^2.2.1(same API, shipsoverrideDefineForWebAppServe), updating imports inenv.ts,vite.config.ts,src/declarations/env.d.ts.web-app-serve/docker-compose.yml: overridable project name, dynamic vars inline with local defaults,.envnow optional.ci:— publish helm wrapper chart viaweb-app-serve-action@v0.2.0publish-web-app-serve.yml→helm-publish.yaml; action bumpedv0.1.1→v0.2.0(helm_publish: true); permissions widened withcontents: read+pull-requests: read(provenance writer resolves the PR from the commit).web-app-serve/helm/(timur-helm), depending onoci://ghcr.io/toggle-corp/web-app-serve-helm:0.1.1aliasedapp. CI stamps image name/tag + provenance annotations and pushes the chart to GHCR on every develop push:oci://ghcr.io/toggle-corp/timur-helm, version0.0.1-develop.c<sha>.Verification
web-app-serve/docker-compose.yml): HTTP 200, 0 leftoverWEB_APP_SERVE_PLACEHOLDER__*markers in served files, runtime substitution + override confirmed.helm dependency update+lint+templateall pass.WEB_APP_SERVE_ENABLED)pnpm buildstill passes.TODO before/after merge
feat/web-app-serve-helmentry fromon.push.branchesin.github/workflows/helm-publish.yaml— it exists only to test the publish workflow end-to-end on this branch (publishes toghcr.io/toggle-corp/timur-dev/timur-dev-helmbecause of the slash in the branch name).Notes for deployers (stock
APP_apply-config limitations, pre-existing)The base image's stock apply-config has no sed-metachar escaping and no blank-unfilled step (upstream FIXME), so:
&or|in any runtimeAPP_*value (&silently corrupts the substituted value;|crashes the container at start).APP_*var explicitly at deploy time — use""to opt out of optional ones (APP_UMAMI_SRC,APP_UMAMI_ID,APP_SENTRY_DSN). A truly-unset var leaks its literal placeholder into the bundle; unset umami vars ship a broken<script>tag inindex.html.🤖 Generated with Claude Code